support UNSIGNED modifier with unused parameters of INT#36126
Merged
CurtizJ merged 1 commit intoClickHouse:masterfrom Apr 14, 2022
Merged
support UNSIGNED modifier with unused parameters of INT#36126CurtizJ merged 1 commit intoClickHouse:masterfrom
CurtizJ merged 1 commit intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-improvement
CurtizJ
added
the
can be tested
Member
|
Please, can you add a test? |
awakeljw
force-pushed
the
fork_chmaster2
branch
from
ce07a54 to
eca166b
Compare
Contributor
Author
|
I have added a test. |
awakeljw
force-pushed
the
fork_chmaster2
branch
from
eca166b to
b2c1061
Compare
awakeljw
changed the title
CurtizJ
approved these changes
Apr 14, 2022
Member
|
Integration tests have been broken in master for a while. |
Member
|
@CurtizJ Pull request cannot be merged with failed tests. |
Member
|
@CurtizJ This pull request broke tests. It's reverted, please resubmit it. |
Merged
CurtizJ
added a commit
that referenced
this pull request
Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Support
UNSIGNEDmodifier with unused parameters ofINT