Add ability to strip binaries in cmake#35196
Merged
Conversation
robot-clickhouse
added
the
pr-build
alesapin
commented
Mar 10, 2022
| message (FATAL_ERROR "Cannot find objcopy.") | ||
| endif () | ||
|
|
||
| if (COMPILER_GCC) |
| OBJCOPY_PATH=${3:objcopy} | ||
| READELF_PATH=${4:readelf} | ||
|
|
||
| BUILD_ID=$($READELF_PATH -n $1 | sed -n '/Build ID/ { s/.*: //p; q; }') |
Member
Author
There was a problem hiding this comment.
Now in some cases our build system depend on bash.
Felixoid
reviewed
Mar 11, 2022
| endif () | ||
|
|
||
| # Allows to build stripped binary in a separate directory | ||
| if (OBJCOPY_PATH AND READELF_PATH) |
Member
There was a problem hiding this comment.
Does it mean that BUILD_STRIPPED_BINARIES_PREFIX will be always set according to https://github.com/ClickHouse/ClickHouse/pull/35196/files#diff-20dc468ff5043ade1489346dbd70f621d828a1c8c6a439ef9b0afc3bc295a0a0R178 ?
I don't really think we always want strip it
Member
|
The fuzzer's issue is created, merge it now #35210 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add an ability to build stripped binaries with cmake.