Skip to content

Try to fix failed tests#35073

Merged
alexey-milovidov merged 4 commits intoClickHouse:masterfrom
Avogar:fix-tests
Mar 6, 2022
Merged

Try to fix failed tests#35073
alexey-milovidov merged 4 commits intoClickHouse:masterfrom
Avogar:fix-tests

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Mar 5, 2022

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 5, 2022
@azat
Copy link
Copy Markdown
Member

azat commented Mar 5, 2022

Let's also apply this change then (this problem also had been introduced in #34092):

$ git diff
diff --git a/tests/clickhouse-test b/tests/clickhouse-test
index 4c94e4d6493..121a283d0e4 100755
--- a/tests/clickhouse-test
+++ b/tests/clickhouse-test
@@ -446,7 +446,7 @@ class TestCase:
         else:
             os.environ['CLICKHOUSE_URL_PARAMS'] = self.base_url_params + '&' + '&'.join(self.random_settings)
 
-        new_options = "--allow_repeated_settings --" + " --".join(self.random_settings)
+        new_options = " --allow_repeated_settings --" + " --".join(self.random_settings)
         os.environ['CLICKHOUSE_CLIENT_OPT'] = self.base_client_options + new_options + ' '
         return client_options + new_options

@alexey-milovidov
Copy link
Copy Markdown
Member

Looks like this is for

00001_select_1:                                                         [ FAIL ] - return code: 1
Code: 27. DB::ParsingException: Cannot parse input: expected 'eof' before: '--allow_repeated_settings'. (CANNOT_PARSE_INPUT_ASSERTION_FAILED)

As we have failed "hung check" in stress test in master.

@alexey-milovidov
Copy link
Copy Markdown
Member

Fast test: #35050

@alexey-milovidov
Copy link
Copy Markdown
Member

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 5, 2022

update

✅ Branch has been successfully updated

@alexey-milovidov alexey-milovidov self-assigned this Mar 5, 2022
@alexey-milovidov alexey-milovidov merged commit 1675493 into ClickHouse:master Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants