Fix non-MergeTree engines for system.*_log#34989
Merged
alesapin merged 1 commit intoClickHouse:masterfrom Mar 2, 2022
Merged
Conversation
Fixes: ClickHouse#34949 Signed-off-by: Azat Khuzhin <[email protected]>
robot-clickhouse
added
the
pr-not-for-changelog
alesapin
approved these changes
Mar 2, 2022
Member
alesapin
left a comment
alesapin
left a comment
There was a problem hiding this comment.
Quite ugly, but should work.
Member
|
Any integration test and merge |
Member
Author
Yes, but there are quite a few such places already: ClickHouse/programs/copier/Internals.cpp Line 92 in 8c533b2 |
This was referenced Mar 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix non-MergeTree engines for system.*_log
Fixes: #34949 (cc @alesapin @nikitamikhaylov )