Skip to content

Recreate system.{*}_log table on settings changes#34949

Merged
alesapin merged 1 commit intoClickHouse:masterfrom
nikitamikhaylov:system_log_tables_and_settings
Mar 1, 2022
Merged

Recreate system.{*}_log table on settings changes#34949
alesapin merged 1 commit intoClickHouse:masterfrom
nikitamikhaylov:system_log_tables_and_settings

Conversation

@nikitamikhaylov
Copy link
Copy Markdown
Member

@nikitamikhaylov nikitamikhaylov commented Feb 28, 2022 •
edited
Loading

(cherry picked from commit 4ae445c9e227581ea9f1cbe9aa9d1ba82e1236c9)

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Currently, if the user changes the settings of the system tables there will be tons of logs and ClickHouse will rename the tables every minute. This fixes #34929

@nikitamikhaylov
Better
d6036f6 
(cherry picked from commit 4ae445c9e227581ea9f1cbe9aa9d1ba82e1236c9)
@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Feb 28, 2022
@alesapin
Copy link
Copy Markdown
Member

alesapin commented Mar 1, 2022

Failures are known

@alesapin alesapin merged commit 4b61e47 into ClickHouse:master Mar 1, 2022
@azat
Copy link
Copy Markdown
Member

azat commented Mar 2, 2022 •
edited
Loading

Failures are known

Not really, the problem is that now SETTINGS are applied even for non MergeTree engines and test_system_logs_recreate fails:

2022.03.02 09:01:57.286415 [ 428 ] {} <Error> virtual void DB::SystemLog<DB::QueryThreadLogElement>::savingThreadFunction() [LogElement = DB::QueryThreadLogElement]: Code: 36. DB::Exception: Engine Null doesn't support SETTINGS clause. Currently only the following engines have support for the feature: [RabbitMQ, FileLog, MySQL, MaterializedPostgreSQL, S3, Kafka, Distributed, ReplicatedSummingMergeTree, ExecutablePool, ReplicatedCollapsingMergeTree, Join, Executable, Set, MergeTree, ReplicatedReplacingMergeTree, Memory, URL, ReplicatedVersionedCollapsingMergeTree, VersionedCollapsingMergeTree, Hive, ReplacingMergeTree, COSN, ReplicatedAggregatingMergeTree, File, TinyLog, ReplicatedGraphiteMergeTree, ReplicatedMergeTree, SummingMergeTree, GraphiteMergeTree, CollapsingMergeTree, AggregatingMergeTree, StripeLog, Log]. (BAD_ARGUMENTS), Stack trace (when copying this message, always include the lines below):

@azat azat mentioned this pull request Mar 2, 2022
Merged
azat added a commit to azat/ClickHouse that referenced this pull request Mar 2, 2022
@azat
Fix non-MergeTree engines for system.*_log
a49106e 
Fixes: ClickHouse#34949
Signed-off-by: Azat Khuzhin <[email protected]>
@azat azat mentioned this pull request Mar 2, 2022
Merged
@filimonov
Copy link
Copy Markdown
Contributor

filimonov commented Apr 6, 2022

Actually it is a bug affecting 21.12-22.2

@rschu1ze rschu1ze mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alesapin alesapin alesapin approved these changes

Assignees

No one assigned

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

clickhouse creates lots of system log tables if config storage settings for system log table

5 participants

@nikitamikhaylov @alesapin @azat @filimonov @robot-clickhouse