Skip to content

Do not leave any queries after test finish (and add a check into clickhouse-test)#34924

Merged
alexey-milovidov merged 4 commits intoClickHouse:masterfrom
azat:tests-overlaps
Mar 18, 2022
Merged

Do not leave any queries after test finish (and add a check into clickhouse-test)#34924
alexey-milovidov merged 4 commits intoClickHouse:masterfrom
azat:tests-overlaps

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Feb 26, 2022 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 26, 2022
@azat azat mentioned this pull request Feb 26, 2022
Merged
@azat azat force-pushed the tests-overlaps branch 2 times, most recently from c19a714 to ea6ed46 Compare February 27, 2022 10:27
@azat azat mentioned this pull request Feb 28, 2022
Merged
@azat azat marked this pull request as ready for review February 28, 2022 15:00
@azat
Copy link
Copy Markdown
Member Author

azat commented Feb 28, 2022

Any clue on why CI did not started any checks?

@azat azat force-pushed the tests-overlaps branch from 648c36c to 66cbb46 Compare March 1, 2022 12:45
@azat
Copy link
Copy Markdown
Member Author

azat commented Mar 2, 2022

Integration tests (asan, actions) [1/3] — fail: 1, passed: 654, flaky: 0

Stateless tests (thread, actions) [1/3] — fail: 2, passed: 1278, skipped: 11

2022-03-01 06:39:43 WARNING: ThreadSanitizer: signal-unsafe call inside of a signal (pid=2975)

@azat azat marked this pull request as draft March 2, 2022 10:25
@azat azat mentioned this pull request Mar 2, 2022
Merged
@azat azat force-pushed the tests-overlaps branch from 66cbb46 to 3d5f3d4 Compare March 3, 2022 11:35
@azat azat marked this pull request as ready for review March 3, 2022 11:38
@azat azat force-pushed the tests-overlaps branch 2 times, most recently from f7330a5 to 4cef19f Compare March 3, 2022 12:40
@azat
Copy link
Copy Markdown
Member Author

azat commented Mar 4, 2022

PullRequestCI / FunctionalStatelessTestMsan1 (pull_request) Failing after 1s — FunctionalStatelessTestMsan1

Error: No space left on device : '/home/ubuntu/actions-runner/_diag/Worker_20220304-115922-utc.log'

Stress test (debug, actions) — Killed by signal (in clickhouse-server.log)
Stress test (undefined, actions) — Fatal message in clickhouse-server.log

Stateless tests flaky check (address, actions) — Timeout, fail: 0, passed: 367

  • Timeout is OK

@azat azat force-pushed the tests-overlaps branch from 4cef19f to f47638d Compare March 4, 2022 12:51
@azat
Copy link
Copy Markdown
Member Author

azat commented Mar 4, 2022

After #34092 had been merged, there can be few tests failures in fast-test, can someone add force-test label please?

@azat
Copy link
Copy Markdown
Member Author

azat commented Mar 5, 2022

@mergify update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 5, 2022

update

✅ Branch has been successfully updated

Hey, I reacted but my real name is @Mergifyio

@azat azat force-pushed the tests-overlaps branch from 05db0d9 to b0ff3e9 Compare March 5, 2022 08:50
@azat
Copy link
Copy Markdown
Member Author

azat commented Mar 5, 2022

Stress test (debug, actions) — Hung check failed
Stress test (memory, actions) — Hung check failed
Stress test (thread, actions) — Hung check failed
Stress test (undefined, actions) — Hung check failed

Code: 27. DB::ParsingException: Cannot parse input: expected 'eof' before: '--allow_repeated_settings'. (CANNOT_PARSE_INPUT_ASSERTION_FAILED)

@azat azat force-pushed the tests-overlaps branch 2 times, most recently from 95d46f7 to 715200b Compare March 8, 2022 19:29
@azat
Copy link
Copy Markdown
Member Author

azat commented Mar 8, 2022

Stateless tests flaky check (address, actions) — Timeout, fail: 0, passed: 396

  • Timeout - OK

Stateless tests (release, DatabaseReplicated, actions) [2/2] — fail: 1, passed: 1886, skipped: 43
Stateless tests (ubsan, actions) — fail: 1, passed: 3851, skipped: 17

  • 02015_async_inserts_stress_long - timeout, let's try with no-parallel tag.

azat added 3 commits March 9, 2022 17:29
@azat
tests: fix log_comment (extra quotes)
9a297ce 
Signed-off-by: Azat Khuzhin <[email protected]>
@azat
tests: add check of left queries after each test
8b64b41 
Look at log_comment/current_database for this check under --no-left-queries-check

v2: add no-left-queries-check tag support
Signed-off-by: Azat Khuzhin <[email protected]>
@azat
tests: fix 00900_orc_load parallel invocation
2f6c1bc 
Signed-off-by: Azat Khuzhin <[email protected]>
@azat
tests: do not leave any queries after finish
d28963d 
This should fix issues like [1], where because one query from the
previous test was left the next fails, in this particular report the
problem was that 01281_group_by_limit_memory_tracking fails due to the
query from 01301_aggregate_state_exception_memory_leak was running in
background.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/34919/311f884d3d4215f7f82c2dd66ea51d071d313241/stateless_tests__thread__actions__[2/3].html

v2: wait for queries in 01249_flush_interactive
Signed-off-by: Azat Khuzhin <[email protected]>
@azat azat force-pushed the tests-overlaps branch from 715200b to d28963d Compare March 9, 2022 14:29
@azat
Copy link
Copy Markdown
Member Author

azat commented Mar 9, 2022

Stateless tests flaky check (address, actions) — Timeout, fail: 0, passed: 401

  • Timeout - OK

Stateless tests (debug, actions) [2/3] — fail: 1, passed: 1284, skipped: 18

  • 01059_window_view_event_hop_watch_strict_asc looks unrelated

@alexey-milovidov may you can take a look now please?

@azat
Copy link
Copy Markdown
Member Author

azat commented Mar 16, 2022

@alexey-milovidov friendly ping

@alexey-milovidov alexey-milovidov self-assigned this Mar 18, 2022
@alexey-milovidov alexey-milovidov merged commit f13e436 into ClickHouse:master Mar 18, 2022
@azat azat deleted the tests-overlaps branch March 18, 2022 13:17
tavplubix added a commit that referenced this pull request May 28, 2022
@tavplubix
Revert "Merge pull request #34924 from azat/tests-overlaps"
e33d986 
This reverts commit f13e436, reversing
changes made to aa3c05e.
@tavplubix tavplubix mentioned this pull request Jun 3, 2022
Merged
@azat
Copy link
Copy Markdown
Member Author

azat commented Jun 15, 2022

This PR hits a bash bug (that had been fixed in bash 5.1), you may find details in this gist - https://gist.github.com/azat/affbda3f8c6b5c38648d4ab105777d88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azat @alexey-milovidov @robot-clickhouse