Skip to content

Fix sleepEachRow max time#34909

Closed
novikd wants to merge 8 commits intomasterfrom
sleep-fix
Closed

Fix sleepEachRow max time#34909
novikd wants to merge 8 commits intomasterfrom
sleep-fix

Conversation

@novikd
Copy link
Copy Markdown
Member

@novikd novikd commented Feb 25, 2022

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

sleepEachRow function is now limited to sleep no more than 3 seconds per block. The behaviour is now similar to sleep function.

Related to #34397
cc @alexey-milovidov

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Feb 25, 2022
@Avogar Avogar self-assigned this Feb 28, 2022
Copy link
Copy Markdown
Member

@Avogar Avogar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests should be adjusted

@novikd
Copy link
Copy Markdown
Member Author

novikd commented Mar 21, 2022

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 21, 2022

update

✅ Branch has been successfully updated

@novikd
Copy link
Copy Markdown
Member Author

novikd commented Mar 25, 2022

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 25, 2022

update

✅ Branch has been successfully updated

@alexey-milovidov
Copy link
Copy Markdown
Member

@novikd @Avogar Let's continue.

@alexey-milovidov
Copy link
Copy Markdown
Member

@novikd what a good pull request!

@alexey-milovidov
Copy link
Copy Markdown
Member

@novikd no progress in more than a year.
Continued in #49343.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants