Skip to content

Revert "Revert "Add pool to WriteBufferFromS3""#34219

Merged
KochetovNicolai merged 5 commits intomasterfrom
revert-34212-revert-33291-add-pool-to-s3-write-buffer
Feb 4, 2022
Merged

Revert "Revert "Add pool to WriteBufferFromS3""#34219
KochetovNicolai merged 5 commits intomasterfrom
revert-34212-revert-33291-add-pool-to-s3-write-buffer

Conversation

@KochetovNicolai
Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai commented Feb 1, 2022

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Reverts #34212

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 1, 2022
@KochetovNicolai KochetovNicolai merged commit b92efed into master Feb 4, 2022
@KochetovNicolai KochetovNicolai deleted the revert-34212-revert-33291-add-pool-to-s3-write-buffer branch February 4, 2022 08:00
alesapin added a commit that referenced this pull request Feb 4, 2022
…-33291-add-pool-to-s3-write-buffer"

This reverts commit b92efed, reversing
changes made to ecce006.
alesapin added a commit that referenced this pull request Feb 7, 2022
…2-revert-33291-add-pool-to-s3-write-buffer""

This reverts commit 875e541.
alesapin added a commit that referenced this pull request Feb 8, 2022
…ert-34212-revert-33291-add-pool-to-s3-write-buffer"""

This reverts commit fb77d7a.
alesapin added a commit that referenced this pull request Feb 8, 2022
…ouse/revert-34212-revert-33291-add-pool-to-s3-write-buffer""""

This reverts commit 2bc2ea4.
@amosbird
Copy link
Copy Markdown
Collaborator

amosbird commented Feb 9, 2022

The longest revert chain I've ever seen 😆

@alexey-milovidov
Copy link
Copy Markdown
Member

@KochetovNicolai This PR introduced a bug: #35034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants