Combining our lexer with replxx for better multiple line editing#34114
Merged
alexey-milovidov merged 6 commits intoClickHouse:masterfrom Feb 1, 2022
Merged
Combining our lexer with replxx for better multiple line editing#34114alexey-milovidov merged 6 commits intoClickHouse:masterfrom
alexey-milovidov merged 6 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-improvement
amosbird
force-pushed
the
replxxwithlexer
branch
from
ccc4ef1 to
4673faa
Compare
alexey-milovidov
approved these changes
Jan 29, 2022
Member
|
Some tests need to be updated. |
Collaborator
Author
|
The test failures are significant. It's because our original behavior of case-insensitive completion gets accidentally changed upstream. I've submitted the PR to change it back ClickHouse/replxx#20 . |
amosbird
force-pushed
the
replxxwithlexer
branch
from
294f668 to
ae16b36
Compare
Collaborator
Author
|
CI looks good. No related failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Improving the experience of multiple line editing for clickhouse-client. This is a follow-up of #31123
This PR also contains replxx bump ClickHouse/replxx#19 which fixes #32399
NOTE: This PR extends our lexer in that
\Ghas a special type:TokenType::VerticalDelimiterNOTE: Make sure
--highlightis on (default) to take full advantage.NOTE: This PR also ignores case for history search and completion. (The feature was reverted when we switch to upstream replxx, now it's available officially)