Skip to content

Randomize some settings in functional tests#34092

Merged
Avogar merged 20 commits intoClickHouse:masterfrom
Avogar:random-settings
Mar 4, 2022
Merged

Randomize some settings in functional tests#34092
Avogar merged 20 commits intoClickHouse:masterfrom
Avogar:random-settings

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Jan 28, 2022

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Randomize some settings in functional tests. This closes #32268.

@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Jan 28, 2022
@alexey-milovidov alexey-milovidov self-assigned this Jan 28, 2022
@alexey-milovidov
Copy link
Copy Markdown
Member

optimize_move_to_prewhere = 0|1

@alexey-milovidov
Copy link
Copy Markdown
Member

prefer_localhost_replica = 0|1

@alexey-milovidov
Copy link
Copy Markdown
Member

group_by_two_level_threshold
group_by_two_level_threshold_bytes

With 10% probability set to very low value (to activate always) and with 10% set to very high value (to never activate)

@alexey-milovidov
Copy link
Copy Markdown
Member

distributed_aggregation_memory_efficient = 0|1

@alexey-milovidov
Copy link
Copy Markdown
Member

allow_experimental_parallel_reading_from_replicas = 0|1

@alexey-milovidov
Copy link
Copy Markdown
Member

max_insert_threads with probability 1/2 set it uniformly random 1..16

@alexey-milovidov
Copy link
Copy Markdown
Member

output_format_parallel_formatting = 0|1

@alexey-milovidov
Copy link
Copy Markdown
Member

PS. We can adapt existing tests then add more randomization in subsequent PR.

@alexey-milovidov
Copy link
Copy Markdown
Member

@den-crane @SaltTan Maybe you can recall some problematic settings from your experience.

@tavplubix
Copy link
Copy Markdown
Member

We should print changed settings somewhere in logs to simplify debugging

Co-authored-by: tavplubix <[email protected]>
@Algunenano
Copy link
Copy Markdown
Member

Love the idea but do you really want to introduce them all at once? The last similar thing done was to run under a random timezone and it took weeks and many PRs to stabilize things.

@alexey-milovidov
Copy link
Copy Markdown
Member

I'm ok if it will take weeks.

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Feb 28, 2022

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 28, 2022

update

✅ Branch has been successfully updated

@SaltTan
Copy link
Copy Markdown
Contributor

SaltTan commented Mar 1, 2022

@den-crane @SaltTan Maybe you can recall some problematic settings from your experience.

I'm sorry it took me so long.

  • optimize*
  • enable*
  • use*
  • compile_aggregate_expressions
  • compile_expressions
  • There was an issue with 'read_backoff' once.

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Mar 3, 2022

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 3, 2022

update

✅ Branch has been successfully updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-build Pull request with build/testing/packaging improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Randomization of settings in functional tests.

7 participants