Fix restore S3 disk without detached directories#33730
Merged
Avogar merged 1 commit intoClickHouse:masterfrom Jan 19, 2022
Merged
Fix restore S3 disk without detached directories#33730Avogar merged 1 commit intoClickHouse:masterfrom
Avogar merged 1 commit intoClickHouse:masterfrom
Conversation
Avogar
approved these changes
Jan 19, 2022
This was referenced Jan 19, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 19, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 19, 2022
Avogar
added a commit
that referenced
this pull request
Jan 20, 2022
Backport #33730 to 22.1: Fix restore S3 disk without detached directories
Avogar
added a commit
that referenced
this pull request
Jan 20, 2022
Backport #33730 to 21.12: Fix restore S3 disk without detached directories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Create parent directories in DiskS3::restoreFileOperations method.
Detailed description / Documentation draft:
During restart S3 disk procedure ClckHouse reads operations from log on S3 and reproduses stored operations on files. In this log only file operations, so directories like 'detached' can be missed after that procedure when no one operation uses this directory. In this case trying to restore local metafiles fails with error: