Skip to content

Refactor releasing process#33664

Merged
alesapin merged 16 commits intomasterfrom
release-steps
Mar 22, 2022
Merged

Refactor releasing process#33664
alesapin merged 16 commits intomasterfrom
release-steps

Conversation

@Felixoid
Copy link
Copy Markdown
Member

@Felixoid Felixoid commented Jan 15, 2022

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Migrate package building to nfpm
  • Deprecate release script in favor of packages/build
  • Build everything in clickhouse/binary-builder image (cleanup: clickhouse/deb-builder)
  • Add symbol stripping to cmake (todo: use $prefix/lib/$bin_dir/clickhouse/$binary.debug)
  • Fix issue with DWARF symbols
  • Add Alpine APK packages
  • Rename alien to additional_pkgs

@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Jan 15, 2022
@Felixoid
Copy link
Copy Markdown
Member Author

Need to add the new commit like #32218

@Felixoid Felixoid force-pushed the release-steps branch 2 times, most recently from 88b0805 to 965e61d Compare January 24, 2022 16:18
@Felixoid Felixoid force-pushed the release-steps branch 2 times, most recently from 145c093 to 2fe9faf Compare January 28, 2022 13:39
@Felixoid Felixoid changed the title Fix shellcheck issues in release_lib.sh Refactor releasing process Jan 28, 2022
@Felixoid Felixoid added do not test disable testing on pull request and removed do not test disable testing on pull request labels Feb 7, 2022
@Felixoid Felixoid force-pushed the release-steps branch 2 times, most recently from 34e5e1f to 8d58118 Compare February 14, 2022 10:30
@Felixoid Felixoid force-pushed the release-steps branch 2 times, most recently from 792147f to c728b5a Compare February 21, 2022 13:17
@Felixoid
Copy link
Copy Markdown
Member Author

Felixoid commented Mar 8, 2022

Thing we miss now:

objcopy --only-keep-debug "$binary" "$prefix/lib/debug/$bin_dir/$binary.debug"
tempfile=$(mktemp "$binary.XXXXXX")
objcopy --add-gnu-debuglink="$prefix/lib/$bin_dir/clickhouse/$binary.debug" "$binary" "$tempfile"
if ! strip --strip-all "$tempfile" "$prefix/bin/$binary"; then
  mv "$tempfile" "$prefix/bin/$binary"
fi
rm -f "$tempfile"

@alesapin
Copy link
Copy Markdown
Member

Here: #35196

@Felixoid Felixoid force-pushed the release-steps branch 4 times, most recently from 76cae7a to 69b00a3 Compare March 15, 2022 17:07
@Felixoid Felixoid force-pushed the release-steps branch 4 times, most recently from 38ea1f3 to fde0c89 Compare March 18, 2022 13:49
@Felixoid Felixoid marked this pull request as ready for review March 22, 2022 13:41
@alesapin
Copy link
Copy Markdown
Member

Great!

@alesapin alesapin merged commit 0ab9a9c into master Mar 22, 2022
@alesapin alesapin deleted the release-steps branch March 22, 2022 13:43
@makeavish
Copy link
Copy Markdown

@Felixoid
Copy link
Copy Markdown
Member Author

Felixoid commented Mar 22, 2022

Hi @makeavish, subscribe to #35211

@guoxiaolongzte
Copy link
Copy Markdown
Contributor

guoxiaolongzte commented Jul 1, 2023

docker exec -lt clickhouse/binary-builder:latest
root@ad569b6587a0:/ClickHouse/packages# pwd
/root/ClickHouse/packages
root@ad569b6587a0:
/ClickHouse/packages# ./build --rpm

Current version is 23.6.1.873
Building rpm package for clickhouse-client.yaml
using rpm packager...
matching "./root/usr/bin/clickhouse-compressor": file does not exist

What error is this? I haven't seen any official website introduction

@Felixoid
Copy link
Copy Markdown
Member Author

Felixoid commented Jul 3, 2023

See #51679. The process of building in docker is documented there

update: and it's already deployed https://clickhouse.com/docs/en/development/build#building-in-docker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-build Pull request with build/testing/packaging improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants