Skip to content

Deb aarch64#32911

Merged
alesapin merged 25 commits intomasterfrom
deb-aarch64
Jan 13, 2022
Merged

Deb aarch64#32911
alesapin merged 25 commits intomasterfrom
deb-aarch64

Conversation

@Felixoid
Copy link
Copy Markdown
Member

@Felixoid Felixoid commented Dec 17, 2021 •
edited
Loading

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Rename main to pull_request
  • Add BuilderDebAarch64 to all workflows
  • Use docker buildkit, save building cache to docker hub and reuse it
  • Build x86_64 and arm64 docker images separately, then merge them together to a multi-architecture manifest
  • Tune many docker images to being multi-architecture
  • Use the images from the current PR/commit in the following dependent builds
  • Upgrade mysql client in stateless-tests image
  • Add functional tests for aarch64 for PR actions (forced green for a while)
  • Add python typing to some scripts
  • Add docker buildkit to runners' init script
  • Add func-tester-aarch64 runners
  • Use docker login --password-stdin to not expose password on exception

@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Dec 17, 2021
alesapin
alesapin reviewed Dec 21, 2021
View reviewed changes
@Felixoid Felixoid force-pushed the deb-aarch64 branch 3 times, most recently from 6a5f48d to cf4b89f Compare December 23, 2021 10:55
@Felixoid Felixoid mentioned this pull request Dec 23, 2021
Merged
@Felixoid Felixoid force-pushed the deb-aarch64 branch 7 times, most recently from 1ad635d to 868a16e Compare December 24, 2021 16:17
qoega
qoega reviewed Dec 27, 2021
View reviewed changes
@Felixoid Felixoid force-pushed the deb-aarch64 branch 3 times, most recently from be645e9 to 9f6d3e2 Compare January 4, 2022 13:50
@Felixoid Felixoid force-pushed the deb-aarch64 branch 3 times, most recently from 7754a26 to 09431e2 Compare January 6, 2022 13:15
@Felixoid Felixoid requested review from alesapin and qoega January 7, 2022 16:39
@Felixoid
Copy link
Copy Markdown
Member Author

Felixoid commented Jan 10, 2022

It has broken MySQL odbc currently =\

@Felixoid Felixoid force-pushed the deb-aarch64 branch 2 times, most recently from fb9bb75 to b070870 Compare January 10, 2022 18:43
This was linked to issues Jan 11, 2022
Add tests for AArch64 version of ClickHouse to CI #15174
Closed
Official ARM image for Docker #22222
Closed
Felixoid added 17 commits January 12, 2022 17:07
@Felixoid
Fix dpkg-deb architecture-dependent artifact
624dfda
@Felixoid
EXPERIMENT: move docker building to gravitons
198c3f5
@Felixoid
Build dependent images from the current version
2a83a1c
@Felixoid
Use cache feature of docker buildx
7bc89c4
@Felixoid
Don't build image for arm64 pvs-sturio
565e469
@Felixoid
Use mysql-client-8.0 from ubuntu original repo
18a9aac
@Felixoid
Improve integration tests image
7a36983 
- Order packages
- Add rpm2cpio package
- Clean cache
- Use apache CDN for zookeeper
@Felixoid
Use a library with proper architecture for mysql odbc
d1b14d5
@Felixoid
Add necessary 'before' field for a dummy object
341feb5
@Felixoid
Build docker amd64 and arm64 separately and merge together later
2ae87ad
@Felixoid
Use architecture specific version of minio
8779b67
@Felixoid
Apply black to metrics lambda app
6373943
@Felixoid
Add func-testers-aarch64 group to metrics
11ede97
@Felixoid
Build arch-dependent images in every workflow
7fa5d6a
@Felixoid
Add necessary MLIR dependency for codebrowser
651b22f
@Felixoid
Apply black to status_helper.py
0e536d5
@Felixoid
Force success aarch stateless tests
abd16eb
@alesapin alesapin self-assigned this Jan 13, 2022
alesapin
alesapin approved these changes Jan 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@alesapin alesapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

docker/test/codebrowser/Dockerfile
RUN sed -i "s|http://archive.ubuntu.com|$apt_archive|g" /etc/apt/sources.list

RUN apt-get update && apt-get --yes --allow-unauthenticated install clang-13 libllvm13 libclang-13-dev
RUN apt-get update && apt-get --yes --allow-unauthenticated install clang-13 libllvm13 libclang-13-dev libmlir-13-dev
Copy link
Copy Markdown
Member

@alesapin alesapin Jan 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need this fix separately.

Copy link
Copy Markdown
Member Author

@Felixoid Felixoid Jan 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker build fails now w/o it. But I can for sure make it separately.

@Felixoid Felixoid force-pushed the deb-aarch64 branch 3 times, most recently from 85469de to b06188e Compare January 13, 2022 15:29
@alesapin
Copy link
Copy Markdown
Member

alesapin commented Jan 13, 2022

Let's merge.

@alesapin
Copy link
Copy Markdown
Member

alesapin commented Jan 13, 2022

Style check is green.

@alesapin alesapin merged commit 0804e04 into master Jan 13, 2022
@alesapin alesapin deleted the deb-aarch64 branch January 13, 2022 16:11
@Felixoid Felixoid mentioned this pull request Jan 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alesapin alesapin alesapin approved these changes

@qoega qoega Awaiting requested review from qoega

Assignees

@alesapin alesapin

Labels

pr-build Pull request with build/testing/packaging improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Official ARM image for Docker Add tests for AArch64 version of ClickHouse to CI

4 participants

@Felixoid @alesapin @qoega @robot-clickhouse