Skip to content

Make 01675_distributed_bytes_to_delay_insert less flaky (use http over client)#32492

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:fix-01675_distributed_bytes_to_delay_insert
Dec 16, 2021
Merged

Make 01675_distributed_bytes_to_delay_insert less flaky (use http over client)#32492
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:fix-01675_distributed_bytes_to_delay_insert

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Dec 10, 2021

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

client is too heavy in debug builds, switching to http reduces test time
from 22s to 9s overall.

And also drop _long suffix from the file name.

CI: https://s3.amazonaws.com/clickhouse-test-reports/32303/24751e7d45d94541be854c86ce46d65c2e0f66da/stateless_tests__debug__actions_.html

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 10, 2021
@azat azat marked this pull request as draft December 10, 2021 11:13
…r client)

client is too heavy in debug builds, switching to http reduces test time
from 22s to 9s overall.

And also drop `_long` suffix form file name, since `clickhouse-test`
support `Tags` in tests.

CI: https://s3.amazonaws.com/clickhouse-test-reports/32303/24751e7d45d94541be854c86ce46d65c2e0f66da/stateless_tests__debug__actions_.html

v2: relax pattern
@azat azat force-pushed the fix-01675_distributed_bytes_to_delay_insert branch from b6f2d97 to 9aeaa33 Compare December 10, 2021 18:44
@azat azat marked this pull request as ready for review December 10, 2021 21:16
@azat
Copy link
Copy Markdown
Member Author

azat commented Dec 16, 2021

Integration tests (asan, actions) — fail: 11, passed: 1780, flaky: 0
Integration tests (release, actions) — fail: 11, passed: 1781, flaky: 1
Integration tests (thread, actions) — fail: 11, passed: 1781, flaky: 0

  • test_dictionaries_all_layouts_separate_sources/test_mongo.py*
  • test_storage_mongodb
Cannot authenticate in MongoDB

Looks like fixed in upstream/master already, but anyway does not related to this patch.

@alexey-milovidov alexey-milovidov self-assigned this Dec 16, 2021
@alexey-milovidov alexey-milovidov merged commit ccd4d2f into ClickHouse:master Dec 16, 2021
@azat azat deleted the fix-01675_distributed_bytes_to_delay_insert branch December 17, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants