Skip to content

Fix division by zero in avgWeighted with Decimal argument#32303

Merged
tavplubix merged 4 commits intomasterfrom
fix_32053
Dec 7, 2021
Merged

Fix division by zero in avgWeighted with Decimal argument#32303
tavplubix merged 4 commits intomasterfrom
fix_32053

Conversation

@tavplubix
Copy link
Copy Markdown
Member

@tavplubix tavplubix commented Dec 6, 2021

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed crash with SIGFPE in aggregate function avgWeighted with Decimal argument. Fixes #32053

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Dec 6, 2021
@tavplubix tavplubix added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Dec 6, 2021
@novikd novikd self-assigned this Dec 6, 2021
novikd
novikd approved these changes Dec 6, 2021
View reviewed changes
@tavplubix tavplubix marked this pull request as draft December 6, 2021 19:42
@tavplubix tavplubix marked this pull request as ready for review December 6, 2021 19:51
@tavplubix
Copy link
Copy Markdown
Member Author

tavplubix commented Dec 7, 2021

Stateless tests (address, actions) - 02125_many_mutations - bad test, known issue
Stateless tests (debug, actions) - 02125_many_mutations
Stateless tests (debug, actions) - 01675_distributed_bytes_to_delay_insert_long is flaky, cc: @azat
Stateless tests (memory, actions) - 02125_many_mutations again
Stateless tests (thread, actions) - 02125_many_mutations
Stateless tests (thread, actions) - 02050_client_profile_events - Timeout, cc: @azat
Style Check - Shellcheck - broken in master

@tavplubix tavplubix requested a review from novikd December 7, 2021 09:10
@tavplubix tavplubix merged commit 6c16348 into master Dec 7, 2021
@tavplubix tavplubix deleted the fix_32053 branch December 7, 2021 10:32
This was referenced Dec 7, 2021
Merged
Merged
Merged
Merged
Closed
robot-clickhouse pushed a commit that referenced this pull request Dec 7, 2021
Backport #32303 to 21.10: Fix division by zero in avgWeighted with De…
5e51883 
…cimal argument
@robot-clickhouse robot-clickhouse mentioned this pull request Dec 7, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request Dec 7, 2021
Backport #32303 to 21.8: Fix division by zero in avgWeighted with Dec…
dbf7466 
…imal argument
@robot-clickhouse robot-clickhouse mentioned this pull request Dec 7, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request Dec 7, 2021
Backport #32303 to 21.11: Fix division by zero in avgWeighted with De…
6c19bdf 
…cimal argument
@robot-clickhouse robot-clickhouse mentioned this pull request Dec 7, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request Dec 7, 2021
Backport #32303 to 21.9: Fix division by zero in avgWeighted with Dec…
5cc47e8 
…imal argument
@robot-clickhouse robot-clickhouse mentioned this pull request Dec 7, 2021
Merged
alexey-milovidov added a commit that referenced this pull request Dec 9, 2021
@alexey-milovidov
Merge pull request #32354 from ClickHouse/backport/21.11/32303
c27fbb9 
Backport #32303 to 21.11: Fix division by zero in avgWeighted with Decimal argument
tavplubix added a commit that referenced this pull request Dec 9, 2021
@tavplubix
Merge pull request #32352 from ClickHouse/backport/21.10/32303
b65f569 
Backport #32303 to 21.10: Fix division by zero in avgWeighted with Decimal argument
tavplubix added a commit that referenced this pull request Dec 9, 2021
@tavplubix
Merge pull request #32355 from ClickHouse/backport/21.9/32303
af6b6b7 
Backport #32303 to 21.9: Fix division by zero in avgWeighted with Decimal argument
@azat
Copy link
Copy Markdown
Member

azat commented Dec 10, 2021

Stateless tests (debug, actions) - 01675_distributed_bytes_to_delay_insert_long is flaky, cc: @azat

Stateless tests (thread, actions) - 02050_client_profile_events - Timeout, cc: @azat

tavplubix added a commit that referenced this pull request Dec 16, 2021
@tavplubix
Merge pull request #32353 from ClickHouse/backport/21.8/32303
233cde2 
Backport #32303 to 21.8: Fix division by zero in avgWeighted with Decimal argument
@Felixoid Felixoid added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@novikd novikd novikd approved these changes

Assignees

@novikd novikd

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash in avgWeighted with Decimal

5 participants

@tavplubix @azat @novikd @Felixoid @robot-clickhouse