Fix versioning of aggregate functions (fixes performance tests)#32236
Merged
kssenii merged 2 commits intoClickHouse:masterfrom Dec 6, 2021
Merged
Fix versioning of aggregate functions (fixes performance tests)#32236kssenii merged 2 commits intoClickHouse:masterfrom
kssenii merged 2 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
kssenii
reviewed
Dec 5, 2021
Member
There was a problem hiding this comment.
Also may be in line 79.. Passing version to set from here
As I see from a quick look it is the only place where set is used.
azat
force-pushed
the
fix-agg-func-versioning
branch
from
91a68e8 to
2b1789a
Compare
kssenii
approved these changes
Dec 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix versioning of aggregate functions (fixes performance tests)
Fixes: #24820 (cc @kssenii )
NOTE: marked as
Not for changelogsince original PR had not been included into any stable release yet