Skip to content

Create release workflow#32218

Merged
Felixoid merged 6 commits intomasterfrom
release-workflow
Jan 19, 2022
Merged

Create release workflow#32218
Felixoid merged 6 commits intomasterfrom
release-workflow

Conversation

@Felixoid
Copy link
Copy Markdown
Member

@Felixoid Felixoid commented Dec 3, 2021 •
edited
Loading

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add action for published releases

Detailed description / Documentation draft:
When releases v\d\d[.]\d+[.]\d+[.]\d+-(testing|prestable|stable|lts) are published, the workflow will:

  • Download binary packages from S3
  • Upload them to artifactory
  • Push them to release assets

@Felixoid Felixoid requested a review from alesapin December 3, 2021 17:36
@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Dec 3, 2021
@alesapin alesapin self-assigned this Dec 9, 2021
alesapin
alesapin reviewed Dec 9, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alesapin alesapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we still need to do all other release-related staff:

  1. We have to manually update several files in repository. Look at the recent commit from the old release script for tweak releases: 9b13386 and 1a254b9.
  2. For new patch release (21.11 -> 21.12) we also need to create new PR like #32419 and change something in master f2ccddb.
  3. Push new docker (clickhouse/clickhouse-server and clickhouse/clickhouse-client) images to dockerhub.
  4. Some docs how to create release.

@Felixoid Felixoid force-pushed the release-workflow branch 4 times, most recently from 6eb20f9 to b966f8e Compare January 17, 2022 08:42
@Felixoid Felixoid mentioned this pull request Jan 19, 2022
Merged
@Felixoid
Rename release action to docs to reflect the content
d3accef
@Felixoid
Improve push_to_artifactory
7fd6290 
- Add tgz archives
- Add --all argument for all packages download
- Add -n to skip pushing to artifactory
- Add help for artifactory-url
- Make 3.8 compatible
- Add cleanup `refs/tags/` from --release argument
@Felixoid
Create release workflow
e016629
@Felixoid
Fix some linter issues
13368bf
@Felixoid
Add option to skip redownload, push tgz
3142ae9
@Felixoid
Improve typing and arguments
d9a1284
@Felixoid
Copy link
Copy Markdown
Member Author

Felixoid commented Jan 19, 2022

The arm64 packages will be addressed in #33664

alesapin
alesapin approved these changes Jan 19, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@alesapin alesapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we will need to update docs_release workflow id in rerun lambda.

@Felixoid
Copy link
Copy Markdown
Member Author

Felixoid commented Jan 19, 2022 •
edited
Loading

For history, now DocksReleaseCheck is:

    {
      "id": 14738810,
      "node_id": "W_kwDOA5dJV84A4OV6",
      "name": "DocsReleaseChecks",
      "path": ".github/workflows/release.yml",
      "state": "active",
      "created_at": "2021-10-30T08:21:55.000Z",
      "updated_at": "2022-01-17T23:04:40.000Z",
      "url": "https://api.github.com/repos/ClickHouse/ClickHouse/actions/workflows/14738810",
      "html_url": "https://github.com/ClickHouse/ClickHouse/blob/master/.github/workflows/release.yml",
      "badge_url": "https://github.com/ClickHouse/ClickHouse/workflows/DocsReleaseChecks/badge.svg"
    },

After merge it's changed to:

    {
      "id": 18247056,
      "node_id": "W_kwDOA5dJV84BFm2Q",
      "name": "DocsReleaseChecks",
      "path": ".github/workflows/docs_release.yml",
      "state": "active",
      "created_at": "2022-01-19T15:22:04.000Z",
      "updated_at": "2022-01-19T15:22:04.000Z",
      "url": "https://api.github.com/repos/ClickHouse/ClickHouse/actions/workflows/18247056",
      "html_url": "https://github.com/ClickHouse/ClickHouse/blob/master/.github/workflows/docs_release.yml",
      "badge_url": "https://github.com/ClickHouse/ClickHouse/workflows/DocsReleaseChecks/badge.svg"
    }

@Felixoid Felixoid merged commit 4cb86ad into master Jan 19, 2022
@Felixoid Felixoid deleted the release-workflow branch January 19, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alesapin alesapin alesapin approved these changes

Assignees

@alesapin alesapin

Labels

pr-build Pull request with build/testing/packaging improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Felixoid @alesapin @robot-clickhouse