Fix detaching parts with projections#32067
Merged
KochetovNicolai merged 1 commit intoClickHouse:masterfrom Dec 13, 2021
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
amosbird
force-pushed
the
projection-fix23
branch
from
f2285b6 to
8dbc7a8
Compare
KochetovNicolai
approved these changes
Dec 2, 2021
Member
|
Stateful debug: |
This was referenced Dec 13, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Dec 14, 2021
Backport #32067 to 21.12: Fix detaching parts with projections
KochetovNicolai
added a commit
that referenced
this pull request
Dec 20, 2021
Backport #32067 to 21.10: Fix detaching parts with projections
KochetovNicolai
added a commit
that referenced
this pull request
Dec 20, 2021
Backport #32067 to 21.11: Fix detaching parts with projections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix unexpected projection removal when detaching parts.
Detailed description / Documentation draft:
I don't understand why we introduced the
max_levelargument at the first place (#2217). Let's see if removing it can break any tests.