Support toUInt8/toInt8 for if constant condition optimization.#31866
Merged
alexey-milovidov merged 2 commits intomasterfrom Nov 30, 2021
Merged
Support toUInt8/toInt8 for if constant condition optimization.#31866alexey-milovidov merged 2 commits intomasterfrom
alexey-milovidov merged 2 commits intomasterfrom
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
KochetovNicolai
added
the
pr-must-backport
| } | ||
| } | ||
| } | ||
| else if (function->name == "toUInt8" || function->name == "toInt8") |
Member
There was a problem hiding this comment.
Do we still need OptimizeIfWithConstantCondition?
Also maybe make a setting to disable this optimization?
Member
Author
There was a problem hiding this comment.
Looks like we need it, there is no other way to skip unused columns
Member
There was a problem hiding this comment.
Where exactly it is needed?
alexey-milovidov
requested changes
Nov 26, 2021
Member
alexey-milovidov
left a comment
alexey-milovidov
left a comment
There was a problem hiding this comment.
The change looks ad-hoc.
Member
|
What if any other function will be used? |
alexey-milovidov
approved these changes
Nov 29, 2021
This was referenced Nov 30, 2021
Merged
Merged
Merged
Merged
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 30, 2021
…ition optimization.
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 30, 2021
…ition optimization.
KochetovNicolai
added a commit
that referenced
this pull request
Dec 2, 2021
Backport #31866 to 21.11: Support toUInt8/toInt8 for if constant condition optimization.
KochetovNicolai
added a commit
that referenced
this pull request
Dec 2, 2021
Backport #31866 to 21.3: Support toUInt8/toInt8 for if constant condition optimization.
KochetovNicolai
added a commit
that referenced
this pull request
Dec 2, 2021
Backport #31866 to 21.9: Support toUInt8/toInt8 for if constant condition optimization.
KochetovNicolai
added a commit
that referenced
this pull request
Dec 2, 2021
Backport #31866 to 21.10: Support toUInt8/toInt8 for if constant condition optimization.
KochetovNicolai
added a commit
that referenced
this pull request
Dec 2, 2021
Backport #31866 to 21.8: Support toUInt8/toInt8 for if constant condition optimization.
Felixoid
added
the
pr-backports-created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Fixes #31687