Skip to content

Build clickhouse-keeper with Musl#31833

Merged
alesapin merged 67 commits intomasterfrom
musl-check
Apr 22, 2022
Merged

Build clickhouse-keeper with Musl#31833
alesapin merged 67 commits intomasterfrom
musl-check

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Nov 25, 2021 •
edited by alesapin
Loading

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Now clickhouse-keeper for the x86_64 architecture is statically linked with musl and doesn't depend on any system libraries.

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 25, 2021
@robot-ch-test-poll3 robot-ch-test-poll3 added the submodule changed At least one submodule changed in this PR. label Nov 29, 2021
@alexey-milovidov alexey-milovidov mentioned this pull request Dec 24, 2021
Merged
@alexey-milovidov alexey-milovidov removed the submodule changed At least one submodule changed in this PR. label Jan 9, 2022
@alexey-milovidov alexey-milovidov mentioned this pull request Jan 26, 2022
Merged
@alesapin alesapin changed the title Check what will happen if we build ClickHouse with Musl Build clickhouse-keeper with Musl Apr 12, 2022
@alesapin alesapin marked this pull request as ready for review April 12, 2022 16:49
@robot-ch-test-poll1 robot-ch-test-poll1 added the submodule changed At least one submodule changed in this PR. label Apr 12, 2022
@alesapin
Copy link
Copy Markdown
Member

alesapin commented Apr 13, 2022

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 13, 2022

update

✅ Branch has been successfully updated

@alesapin alesapin self-assigned this Apr 13, 2022
@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Apr 18, 2022

Need to merge with master after #36337.

@alesapin
Copy link
Copy Markdown
Member

alesapin commented Apr 20, 2022

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 20, 2022

update

☑️ Nothing to do

Details
  • -closed [:pushpin: update requirement]
  • #commits-behind>0 [:pushpin: update requirement]

@alesapin
Copy link
Copy Markdown
Member

alesapin commented Apr 20, 2022

clear to me now -- we don't need to disable the embedded keeper build at all. We need to avoid symlink creation.

@alesapin
Copy link
Copy Markdown
Member

alesapin commented Apr 21, 2022

Works now

@alesapin
Copy link
Copy Markdown
Member

alesapin commented Apr 21, 2022

Waiting for all tests.

@alesapin
Copy link
Copy Markdown
Member

alesapin commented Apr 22, 2022 •
edited
Loading

02180_group_by_lowcardinality -- flaky test, already reported.

@alesapin
Copy link
Copy Markdown
Member

alesapin commented Apr 22, 2022

Clear win:
image

Felixoid
Felixoid requested changes Apr 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Felixoid Felixoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There're last things to check

alesapin and others added 3 commits April 22, 2022 11:30
@alesapin @Felixoid
Update CMakeLists.txt
00f683f 
Co-authored-by: Mikhail f. Shiryaev <[email protected]>
@alesapin @Felixoid
Update docker/packager/packager
c2a881d 
Co-authored-by: Mikhail f. Shiryaev <[email protected]>
@alesapin @Felixoid
Update programs/CMakeLists.txt
f88f654 
Co-authored-by: Mikhail f. Shiryaev <[email protected]>
@robot-clickhouse robot-clickhouse added pr-build Pull request with build/testing/packaging improvement and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Apr 22, 2022
Felixoid
Felixoid approved these changes Apr 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Felixoid Felixoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait for builds

@Felixoid Felixoid force-pushed the musl-check branch 2 times, most recently from 156a98b to 4091f0d Compare April 22, 2022 13:45
@alesapin
Copy link
Copy Markdown
Member

alesapin commented Apr 22, 2022

Finally we did it.

@alesapin alesapin merged commit 7380a71 into master Apr 22, 2022
@alesapin alesapin deleted the musl-check branch April 22, 2022 20:41
@tavplubix tavplubix mentioned this pull request Apr 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Felixoid Felixoid Felixoid approved these changes

Assignees

@alesapin alesapin

Labels

pr-build Pull request with build/testing/packaging improvement submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@alexey-milovidov @alesapin @Felixoid @robot-clickhouse @robot-ch-test-poll1 @robot-ch-test-poll3 @thomoco @yjant @ucasfl