02010_lc_native: Generate a new id for each query#31720
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Nov 25, 2021
Merged
02010_lc_native: Generate a new id for each query#31720alexey-milovidov merged 1 commit intoClickHouse:masterfrom
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
azat
reviewed
Nov 24, 2021
| CLICKHOUSE_HOST = os.environ.get('CLICKHOUSE_HOST', '127.0.0.1') | ||
| CLICKHOUSE_PORT = int(os.environ.get('CLICKHOUSE_PORT_TCP', '900000')) | ||
| CLICKHOUSE_DATABASE = os.environ.get('CLICKHOUSE_DATABASE', 'default') | ||
| CLICKHOUSE_QUERY_ID = uuid.uuid4().hex |
Member
There was a problem hiding this comment.
Nice catch. By the way we can simply send empty string instead of query_id and server will take care about this (create random UUID for query_id by itself).
alexey-milovidov
approved these changes
Nov 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Detailed description / Documentation draft:
Attempt to fix #31653 by generating a new random id for each query
Closes #31653 (Hopefully, since I haven't been able to reproduce it locally)