Fix MySQLWire format (this will also fix performance tests) #31565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of multiple writes File() engine will set doNotWritePrefix(), and this will avoid serializations initilization, move this to do this always. Fixes: ClickHouse#31004
robot-clickhouse
added
the
pr-not-for-changelog
This was referenced Nov 20, 2021
Avogar
approved these changes
Nov 20, 2021
Member
Author
|
I guess the query is errored in the clickhouse-server from upstream. Stateless tests (memory, actions) — fail: 1, passed: 3543, skipped: 14 |
This was referenced Nov 21, 2021
azat
changed the title
alexey-milovidov
approved these changes
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix MySQLWire format (in case of multiple writes)
Detailed description / Documentation draft:
In case of multiple writes File() engine will set doNotWritePrefix(),
and this will avoid serializations initilization, move this to do this
always.
Note, that this will also fix performance tests in master (in PRs not all tests will be run, so most of the time they will be ok)
Fixes: #31004 (cc @Avogar )
NOTE: Marked as
Not for changelogsince original PR has not been included into any stable release yet