Merged
Conversation
…. [#CLICKHOUSE-3903]
KochetovNicolai
force-pushed
the
low-cardinality-group-by
branch
from
a456a77 to
a2eb72c
Compare
| /// The same as getNestedColumn, but removes null map if nested column is nullable. | ||
| virtual const ColumnPtr & getNestedNotNullableColumn() const = 0; | ||
|
|
||
| virtual const UInt64 * tryGetSavedHash() const = 0; |
Member
There was a problem hiding this comment.
Missing comment (about the purpose of this method).
| static MutableColumnUniquePtr createColumnUniqueImpl(const IDataType & keys_type, const Creator & creator); | ||
| }; | ||
|
|
||
| DataTypePtr removeLowCardinality(const DataTypePtr & type); |
dbms/src/Interpreters/Aggregator.h
Outdated
| /** Do not use optimization for consecutive keys. | ||
| */ | ||
| static const bool no_consecutive_keys_optimization = false; | ||
| static const bool no_consecutive_keys_optimization = true; |
dbms/src/Interpreters/Aggregator.h
Outdated
| static_cast<ColumnVector<FieldType> *>(key_columns[0].get())->insertData(reinterpret_cast<const char *>(&value.first), sizeof(value.first)); | ||
| } | ||
|
|
||
| static StringRef getRef(const typename Data::value_type & value) |
Member
There was a problem hiding this comment.
Does it mean "getKeyRef"? If so, why we pass value_type instead of key?
dbms/src/Interpreters/Aggregator.h
Outdated
| static const bool no_consecutive_keys_optimization = false; | ||
| static const bool no_consecutive_keys_optimization = true; | ||
| /// Use optimization for low cardinality. | ||
| static constexpr bool low_cardinality_optimization = false; |
Member
There was a problem hiding this comment.
Inconsistent const/constexpr.
| @@ -549,15 +596,19 @@ void NO_INLINE Aggregator::executeImplCase( | |||
| /// NOTE When editing this code, also pay attention to SpecializedAggregator.h. | |||
dbms/src/Interpreters/Aggregator.cpp
Outdated
| else if (result.type == AggregatedDataVariants::Type::NAME) \ | ||
| executeImpl(*result.NAME, result.aggregates_pool, rows, key_columns, aggregate_functions_instructions.data(), \ | ||
| key, no_more_keys, overflow_row_ptr); | ||
| key, no_more_keys, overflow_row_ptr); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en