Merged
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
kssenii
added
the
pr-must-backport
alesapin
reviewed
Nov 12, 2021
Member
alesapin
left a comment
alesapin
left a comment
There was a problem hiding this comment.
How only type change can help? Probably we need to change something in code?
Member
Author
|
it is not type change, is is the same as it was, but removed initialization of std::optional, it must not contain a value.. |
alesapin
approved these changes
Nov 12, 2021
This was referenced Nov 12, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 12, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Nov 12, 2021
Backport #31325 to 21.11: Fix check in async buffer
Felixoid
added
the
pr-backports-created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Broke it 3 days ago in #31112.
It broke case when async reads were turned on with non-MergeTree tables.
Later it will not get broken again because now async reads will be turn on in all tests after #31291.
Backporting it because fix #31112, which broke it, was also backported.