Skip to content

Try to show race in flushing data in ParallelFormattingOutputFormat#31011

Closed
Avogar wants to merge 3 commits intoClickHouse:masterfrom
Avogar:test-race
Closed

Try to show race in flushing data in ParallelFormattingOutputFormat#31011
Avogar wants to merge 3 commits intoClickHouse:masterfrom
Avogar:test-race

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Nov 2, 2021

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 2, 2021
@Avogar Avogar marked this pull request as draft November 2, 2021 19:01
@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Nov 2, 2021

With 1 sec sleep in client this scenario doesn't work properly:

$ timeout 5 clickhouse-client -q "select distinct number % 5 from system.numbers" --max_execution_time=10

Disabling output_format_parallel_formatting helps:

$ timeout 5 clickhouse-client -q "select distinct number % 5 from system.numbers" --max_execution_time=10 --output_format_parallel_formatting=0
0
1
2
3
4

@nikitamikhaylov nikitamikhaylov self-assigned this Nov 2, 2021
@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Nov 3, 2021

@nikitamikhaylov Thanks for the fix. Seems like no problems with performance test. I will cose this PR and will add your fix in my PR #31004. Ok?

@nikitamikhaylov
Copy link
Copy Markdown
Member

@nikitamikhaylov Thanks for the fix. Seems like no problems with performance test. I will cose this PR and will add your fix in my PR #31004. Ok?

Sure

@Avogar Avogar closed this Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants