Small refactoring in formats#31004
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Fast test failure: #31011 |
Avogar
force-pushed
the
output-formats
branch
from
76f0c7e to
2dd4393
Compare
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
|
| ${CLICKHOUSE_CLIENT} --query "CREATE TABLE file (x UInt64) ENGINE = File(TSV, '${CLICKHOUSE_DATABASE}/${m}.tsv.${m}')" | ||
| ${CLICKHOUSE_CLIENT} --query "TRUNCATE TABLE file" | ||
| ${CLICKHOUSE_CLIENT} --query "INSERT INTO file SELECT * FROM numbers(1000000)" | ||
| sleep 1 |
There was a problem hiding this comment.
Actually seems that this PR likely breaks performance tests - https://clickhouse-test-reports.s3.yandex.net/0/fc9ef14a736d62f121d27d3a23490ef7198190be/performance_comparison/report.html#fail1
There was a problem hiding this comment.
Actually seems that this PR likely breaks performance tests - https://clickhouse-test-reports.s3.yandex.net/0/fc9ef14a736d62f121d27d3a23490ef7198190be/performance_comparison/report.html#fail1
There was a problem hiding this comment.
Actually seems that this PR likely breaks performance tests - https://clickhouse-test-?>>reports.s3.yandex.net/0/fc9ef14a736d62f121d27d3a23490ef7198190be/performance_comparison/report.html#fail1
Thanks
In case of multiple writes File() engine will set doNotWritePrefix(), and this will avoid serializations initilization, move this to do this always. Fixes: ClickHouse#31004
5 participants
Changelog category (leave one):
Try to make code in formats a bit better