Executable refactoring#30957
Merged
kitaisreal merged 16 commits intoClickHouse:masterfrom Dec 29, 2021
Merged
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
kitaisreal
force-pushed
the
executable-refactoring
branch
from
9ada6e3 to
848f335
Compare
kitaisreal
requested review from
alexey-milovidov
and removed request for
alexey-milovidov
kitaisreal
force-pushed
the
executable-refactoring
branch
4 times, most recently
from
557e7cf to
b2a51d2
Compare
kitaisreal
force-pushed
the
executable-refactoring
branch
from
b2a51d2 to
49d4619
Compare
kitaisreal
added
the
pr-backward-incompatible
robot-clickhouse
added
pr-improvement
This was referenced Jan 2, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added settings
command_read_timeout,command_write_timeoutforStorageExecutable,StorageExecutablePool,ExecutableDictionary,ExecutablePoolDictionary,ExecutableUserDefinedFunctions. Settingcommand_read_timeoutcontrols timeout for reading data from command stdout in milliseconds. Settingcommand_write_timeouttimeout for writing data to command stdin in milliseconds. Added settingscommand_termination_timeoutforExecutableUserDefinedFunction,ExecutableDictionary,StorageExecutable. Added settingexecute_directforExecutableUserDefinedFunction, by default true. Added settingexecute_directforExecutableDictionary,ExecutablePoolDictionary, by default false.