Conversation
robot-clickhouse
added
doc-alert
pr-feature
Member
Author
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
Member
Author
|
One more time |
Contributor
✅ Branch has been successfully updated |
Member
Author
|
Style check unrelated but let's run tests one more time. |
Member
Author
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
Member
Author
|
Timeouts in integration tests not related, but let's check one more time... a lot of keeper tests were skipped. |
Member
Author
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
Member
Author
|
Timeouts unrelated to changes, flaky check ok. |
Contributor
|
Hello @alesapin , updataKeeperConfiguration breaks non USE_NURAFT build (config not used). |
Contributor
|
Internal documentation ticket: DOCSUP-17658 |
Closed
AVMusorin
reviewed
Feb 11, 2025
| if (diff.empty()) | ||
| LOG_TRACE(log, "Configuration update triggered, but nothing changed for RAFT"); | ||
| else if (diff.size() > 1) | ||
| LOG_WARNING(log, "Configuration changed for more than one server ({}) from cluster, it's strictly not recommended", diff.size()); |
Contributor
There was a problem hiding this comment.
@alesapin It was pretty long ago, but maybe you remember a reason for what could have happened? Or maybe you remember any specific concerns that could arise and help me write a proper test to improve it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add ability to change nodes configuration (in
.xmlfile) for ClickHouse Keeper.