Skip to content

Improve performance of aggregation in order of primary key#30266

Merged
CurtizJ merged 12 commits intoClickHouse:masterfrom
CurtizJ:aggregation-in-order-4
Oct 23, 2021
Merged

Improve performance of aggregation in order of primary key#30266
CurtizJ merged 12 commits intoClickHouse:masterfrom
CurtizJ:aggregation-in-order-4

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Oct 16, 2021

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Improve performance of aggregation in order of primary key (with enabled setting optimize_aggregation_in_order).

@robot-clickhouse robot-clickhouse added the pr-performance Pull request with some performance improvements label Oct 16, 2021
@CurtizJ CurtizJ marked this pull request as draft October 16, 2021 01:36
@CurtizJ CurtizJ marked this pull request as ready for review October 16, 2021 12:41
@CurtizJ CurtizJ marked this pull request as draft October 18, 2021 13:32
@CurtizJ CurtizJ force-pushed the aggregation-in-order-4 branch from ca37d50 to 3e74252 Compare October 18, 2021 16:25
@CurtizJ CurtizJ marked this pull request as ready for review October 18, 2021 18:56
@CurtizJ CurtizJ marked this pull request as draft October 18, 2021 19:21
@KochetovNicolai KochetovNicolai self-assigned this Oct 20, 2021
@CurtizJ CurtizJ marked this pull request as ready for review October 21, 2021 12:08
@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Oct 22, 2021

Test 00150_quantiles_timing_precision fails only in check with DatabaseReplicated
with exception:

[ FAIL ] 0.25 sec. - return code: 49
2021-10-23 02:03:31 [cf4ac8efe393] 2021.10.23 02:03:31.555932 [ 1119 ] {1d00ccd6-6934-4c2b-a4ee-18c0564b4dcc} <Error> executeQuery: Code: 49. DB::Exception: Chunk info was not set for chunk in FinishAggregatingInOrderAlgorithm: While executing FinishAggregatingInOrderTransform. (LOGICAL_ERROR)

It's very strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-performance Pull request with some performance improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants