Preparation to build with Musl#30248
Merged
alexey-milovidov merged 6 commits intomasterfrom Oct 16, 2021
Merged
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
alexey-milovidov
force-pushed
the
musl-4
branch
from
455f163 to
41acc52
Compare
robot-ch-test-poll1
added
the
submodule changed
azat
reviewed
Oct 15, 2021
| #define JEMALLOC_OVERRIDE___LIBC_MEMALIGN | ||
| #define JEMALLOC_OVERRIDE___LIBC_REALLOC | ||
| #define JEMALLOC_OVERRIDE___LIBC_VALLOC | ||
| #if !defined(USE_MUSL) |
Member
There was a problem hiding this comment.
There are also defines for other platforms:
$ gg '#define JEMALLOC_OVERRIDE___LIBC_CALLOC'
contrib/jemalloc-cmake/include_linux_aarch64/jemalloc/internal/jemalloc_internal_defs.h.in:#define JEMALLOC_OVERRIDE___LIBC_CALLOC
contrib/jemalloc-cmake/include_linux_ppc64le/jemalloc/internal/jemalloc_internal_defs.h.in:#define JEMALLOC_OVERRIDE___LIBC_CALLOC
contrib/jemalloc-cmake/include_linux_x86_64/jemalloc/internal/jemalloc_internal_defs.h.in:#define JEMALLOC_OVERRIDE___LIBC_CALLOCOr musl will be used only for x86_64?
Member
Author
There was a problem hiding this comment.
It can be used on multiple platforms and in fact in makes cross-compilation much more easy.
But I did not try Musl on any other platforms, and I don't want to add any changes blindly.
Member
Author
Server also works. |
10 tasks
robot-clickhouse
added
pr-build
Member
Author
|
@azat FYI we can add this build type to CI just in case but now it looks too early. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
ClickHouse can be statically built with Musl. This is added as experiment, it does not support building
odbc-bridge,library-bridge, integration with CatBoost and some libraries.