Backport #29544 to 21.10: Avoid deadlocks on JOIN Engine tables#30182
Merged
alexey-milovidov merged 1 commit intoClickHouse:21.10from Oct 16, 2021
Merged
Backport #29544 to 21.10: Avoid deadlocks on JOIN Engine tables#30182alexey-milovidov merged 1 commit intoClickHouse:21.10from
alexey-milovidov merged 1 commit intoClickHouse:21.10from
Conversation
Algunenano
changed the title
robot-clickhouse
added
the
pr-bugfix
Member
Author
|
The build issue appears because it's testing it with master config (clang 13) and not as a backport. Maybe it needs to be tagged or marked differently, but I don't know how (and I don't have rights to change tags either). |
vdimir
added
pr-backport
robot-clickhouse
added
the
pr-bugfix
robot-clickhouse
added
the
pr-bugfix
Member
|
Let's do optimistic merge... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #29544
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Avoid deadlocks when reading and writting on JOIN Engine tables at the same time
Detailed description / Documentation draft:
Manual backport of #29544 to 21.10 since there were some conflicts and automatic backport didn't work. The idea is to backport it to other stable releases as long as it doesn't require many tweaks on top of the original PR.
Tested by adding the test (
./tests/clickhouse-test 02033_join_engine_deadlock_long) and running it before the changes (blocks and doesn't finish) and after (finishes normally).