Skip to content

Start keeper asynchronously in some cases#30170

Merged
alesapin merged 8 commits intomasterfrom
debug_keeper
Oct 19, 2021
Merged

Start keeper asynchronously in some cases#30170
alesapin merged 8 commits intomasterfrom
debug_keeper

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented Oct 14, 2021

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now Keeper (as part of clickhouse-server) will start asynchronously if it can connect to some other node.

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Oct 14, 2021
@qoega
Copy link
Copy Markdown
Member

qoega commented Oct 14, 2021

And what is the use case?

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Oct 14, 2021

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 14, 2021

Command update: success

Branch has been successfully updated

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Oct 14, 2021

?

When you start fresh empty replica it's better to connect to some other node and receive snapshot/logs from leader asynchronously.

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Oct 15, 2021

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 15, 2021

Command update: success

Branch has been successfully updated

@tavplubix tavplubix self-assigned this Oct 15, 2021
tavplubix
tavplubix reviewed Oct 15, 2021
View reviewed changes
tavplubix
tavplubix reviewed Oct 15, 2021
View reviewed changes
@tavplubix
Copy link
Copy Markdown
Member

tavplubix commented Oct 18, 2021

Integration tests (release) - test_keeper_two_nodes_cluster/test.py::test_read_write_two_nodes_with_blocade

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Oct 18, 2021

Integration tests (release) - test_keeper_two_nodes_cluster/test.py::test_read_write_two_nodes_with_blocade

Actually looks flaky and unrelated to changes.

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Oct 19, 2021

Checked logs from test_keeper_two_nodes_cluster/test.py::test_read_write_two_nodes_with_blocade. Looks like PartitionManager just didn't partition network for some reason: https://gist.github.com/alesapin/9105c15fcbdc79e50e0045487d7ac43e

Or it's a wrong log.

@alesapin alesapin merged commit 53ad965 into master Oct 19, 2021
@alesapin alesapin deleted the debug_keeper branch October 19, 2021 07:14
@alexey-milovidov alexey-milovidov mentioned this pull request Nov 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tavplubix tavplubix tavplubix approved these changes

Assignees

@tavplubix tavplubix

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alesapin @qoega @tavplubix @robot-clickhouse