Skip to content

Make test_MemoryTracking::test_http not flaky#30150

Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
azat:test_MemoryTracking-flap
Oct 14, 2021
Merged

Make test_MemoryTracking::test_http not flaky#30150
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
azat:test_MemoryTracking-flap

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Oct 13, 2021

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

By comparing only megabytes in the memory changes, instead of bytes as
before, since it may be tricky at least due to max_untracked_memory and
how thread pool handle it.

It should be safe, since originally it was written in #16121 which fixes
issue #15932, which has ~4MB consumption of memory per request.

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 13, 2021
This was referenced Oct 13, 2021
Merged
Merged
Merged
Merged
Merged
Merged
@qoega qoega added the testing Special issue with list of bugs found by CI label Oct 14, 2021
@qoega
Copy link
Copy Markdown
Member

qoega commented Oct 14, 2021

Added testing label, as it should help with green master:

| check_name | pull_request_number | check_start_time | test_status | report_url | commit_sha | test_name |

check_name pull_request_number check_start_time test_status report_url commit_sha test_name
Integration tests (release) 0 2021-10-14 09:58:36 FLAKY https://clickhouse-test-reports.s3.yandex.net/0/8d544a55b722728d8c3295ed9c70f6f7db6b6543/integration_tests_(release).html 8d544a5 test_MemoryTracking/test.py::test_http
Integration tests (release) 0 2021-10-14 09:46:25 FLAKY https://clickhouse-test-reports.s3.yandex.net/0/828b19fd51a714805967e880e18972f0a2a93cad/integration_tests_(release).html 828b19f test_MemoryTracking/test.py::test_http
Integration tests (release) 0 2021-10-14 07:35:32 FLAKY https://clickhouse-test-reports.s3.yandex.net/0/a1d349bfff701e7cd4b94545283a257fe6d560e2/integration_tests_(release).html a1d349b test_MemoryTracking/test.py::test_http
Integration tests (release) 29691 2021-10-14 06:56:14 FLAKY https://clickhouse-test-reports.s3.yandex.net/29691/8ef7b558c65da13af496b56c83127c1efc2d7174/integration_tests_(release).html 8ef7b558c65da13af496b56c83127c1efc2d7174 test_MemoryTracking/test.py::test_http
Integration tests (release) 30014 2021-10-14 02:35:11 FLAKY https://clickhouse-test-reports.s3.yandex.net/30014/3d0e595579a641f30b46b3577a66059d87a15e0e/integration_tests_(release).html 3d0e595 test_MemoryTracking/test.py::test_http
Integration tests (release) 29691 2021-10-13 23:50:47 FLAKY https://clickhouse-test-reports.s3.yandex.net/29691/98b1e6f01ed7212ee14a93d696e6926421f0526a/integration_tests_(release).html 98b1e6f01ed7212ee14a93d696e6926421f0526a test_MemoryTracking/test.py::test_http
Integration tests (release) 30064 2021-10-13 23:50:37 FLAKY https://clickhouse-test-reports.s3.yandex.net/30064/5632da03a4ff4fa1bd11ce2fef3b7807d2122ef7/integration_tests_(release).html 5632da03a4ff4fa1bd11ce2fef3b7807d2122ef7 test_MemoryTracking/test.py::test_http
Integration tests (release) 29801 2021-10-13 23:50:28 FLAKY https://clickhouse-test-reports.s3.yandex.net/29801/659a46a9726a45b7bd2aa0819efd2bb600be8c90/integration_tests_(release).html 659a46a test_MemoryTracking/test.py::test_http
Integration tests (release) 29946 2021-10-13 23:50:06 FLAKY https://clickhouse-test-reports.s3.yandex.net/29946/eba6410fd590e93247fce8b4ec3240942e3c01c0/integration_tests_(release).html eba6410 test_MemoryTracking/test.py::test_http
Integration tests (release) 29959 2021-10-13 23:49:36 FLAKY https://clickhouse-test-reports.s3.yandex.net/29959/e4db862d85fb1da177ecbe6f25941eece94aec56/integration_tests_(release).html e4db862 test_MemoryTracking/test.py::test_http

qoega
qoega requested changes Oct 14, 2021
View reviewed changes
azat added 2 commits October 14, 2021 21:06
@azat
Add description for test_MemoryTracking
56ab0e3
@azat
Make test_MemoryTracking::test_http not flaky
d030e08 
By comparing only megabytes in the memory changes, instead of bytes as
before, since it may be tricky at least due to max_untracked_memory and
how thread pool handle it.

It should be safe, since originally it was written in ClickHouse#16121 which fixes
issue ClickHouse#15932, which has ~4MB consumption of memory per request.
@azat azat force-pushed the test_MemoryTracking-flap branch from 05817a8 to d030e08 Compare October 14, 2021 18:06
@azat azat mentioned this pull request Oct 14, 2021
Merged
@azat
Copy link
Copy Markdown
Member Author

azat commented Oct 14, 2021 •
edited
Loading

Integration tests flaky check (asan) — No flaky tests: passed: 3, fail: 0, error: 0, skipped: 0, flaky: 0

Flaky check passed w/o failures.

Functional stateless tests (release, DatabaseReplicated) — fail: 1, passed: 3344, skipped: 118
Functional stateless tests (release, wide parts enabled) — Timeout, fail: 1, passed: 3455, skipped: 2, unknown: 1

Functional stateless tests (thread) — Timeout, fail: 0, passed: 929, skipped: 3, unknown: 8

@alexey-milovidov alexey-milovidov merged commit 9a57fbc into ClickHouse:master Oct 14, 2021
@azat azat deleted the test_MemoryTracking-flap branch October 15, 2021 07:31
@azat azat mentioned this pull request Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qoega qoega qoega requested changes

Assignees

@qoega qoega

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog testing Special issue with list of bugs found by CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@azat @qoega @alexey-milovidov @robot-clickhouse