Skip to content

FunctionsJSON avoid copying object element during iteration#30145

Merged
kitaisreal merged 2 commits intoClickHouse:masterfrom
kitaisreal:functions-json-avoid-copying-object-element-during-iteration
Oct 14, 2021
Merged

FunctionsJSON avoid copying object element during iteration#30145
kitaisreal merged 2 commits intoClickHouse:masterfrom
kitaisreal:functions-json-avoid-copying-object-element-during-iteration

Conversation

@kitaisreal
Copy link
Copy Markdown
Contributor

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 13, 2021
@alexey-milovidov
Copy link
Copy Markdown
Member

@kitaisreal The only reason why this was not found by clang-tidy is that the code is located in header file.
Could you please move to .cpp?

@alexey-milovidov alexey-milovidov self-assigned this Oct 13, 2021
@kitaisreal
Copy link
Copy Markdown
Contributor Author

@alexey-milovidov moved FunctionsJSON to cpp file.

@kitaisreal kitaisreal force-pushed the functions-json-avoid-copying-object-element-during-iteration branch 2 times, most recently from 6103ca0 to ffe1fd2 Compare October 14, 2021 20:10
@kitaisreal kitaisreal force-pushed the functions-json-avoid-copying-object-element-during-iteration branch from ffe1fd2 to 5568461 Compare October 14, 2021 20:11
@kitaisreal kitaisreal merged commit 888c619 into ClickHouse:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants