Merged
Conversation
Member
|
Great! I've looked at the replxx from this PR and here a few bits:
|
Collaborator
Author
I think we should use the upstream's behavior. Add the conversion will be expensive for large history files (we will need to check the file everytime) |
c12989e to
6850025
Compare
6850025 to
b034c91
Compare
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Nov 22, 2021
Before this patch, replxx history_next/history_previous (which were mapped to UP/DOWN) navigates through history lines first (in multi-line mode, and after through history. But it is not convenient, since in case of query contains lots of line it can take awhile. So now, after this update, replxx will change the meaning of history_next/history_previous (which will be binded to M-UP/M-DOWN), those actions will always navigates through history lines. And new actions, line_next/line_previous (binded to UP/DOWN) will navigate through lines of current item first, and when it reaches begin/end it will go the previous/next history item. Also note, that ClickHouse rebind of C-P/C-N is fine, since it is binded to history_next/history_previous, and this is desired (like in readline). Follow-up for: ClickHouse#30143 (cc: @amosbird)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now clickhouse-client supports native multi-line editing.
Switch to upstream replxx because it now contains all our patches plus more features such as multi-line editing. Use
-nalone and paste multiple lines of text to try it out.Detailed description / Documentation draft:
.