Add JSONExtractKeys function#30056
Merged
kitaisreal merged 4 commits intoClickHouse:masterfrom Oct 14, 2021
Merged
Conversation
robot-clickhouse
added
doc-alert
pr-feature
src/Functions/FunctionsJSON.h
Outdated
| auto object = element.getObject(); | ||
|
|
||
| auto & col_arr = assert_cast<ColumnArray &>(dest); | ||
| auto & col_tuple = assert_cast<ColumnTuple &>(col_arr.getData()); |
Member
There was a problem hiding this comment.
Here you have Array(Tuple(String))
Member
There was a problem hiding this comment.
And the correct type is Array(String).
src/Functions/FunctionsJSON.h
Outdated
|
|
||
| static DataTypePtr getReturnType(const char *, const ColumnsWithTypeAndName &) | ||
| { | ||
| return std::make_unique<DataTypeString>(); |
Member
There was a problem hiding this comment.
But here it's just String.
orloffv
force-pushed
the
orloffv.JSONExtractKeys
branch
from
8ef7001 to
b101412
Compare
orloffv
force-pushed
the
orloffv.JSONExtractKeys
branch
from
b101412 to
1623bfa
Compare
Contributor
Author
|
My business case is: perfomance test CREATE TABLE json
(
`json` String
)
ENGINE = MergeTree
ORDER BY jsonINSERT INTO json
SELECT '{"dateTime": "2021-10-13 16:13:36", "additional": {"message_formatted": "Request timeout: search request deadline reached: remaining 2991 ms, exception: ", "thrown_message": "java.util.concurrent.TimeoutException: Request timeout to unknown_host/2a02:31:0:34f00:0:0126:8099 after 1000 ms", "logger": "com.google.test.suggest", "thrown_name": "java.util.concurrent.ExecutionException", "yd_stage": "production-preferences-production-alpha"}}' as json
FROM system.numbers
limit 100000000JSONExtractKeysAndValuesRaw with arrayMap SELECT DISTINCT arrayJoin(arrayMap(x -> tupleElement(x, 1), JSONExtractKeysAndValuesRaw(json)))
FROM jsonJSONExtractKeys SELECT DISTINCT arrayJoin(JSONExtractKeys(json))
FROM json |
kitaisreal
approved these changes
Oct 13, 2021
Contributor
Author
|
@alexey-milovidov do you know better query for my case? |
Member
|
@orloffv This query is Ok. @kitaisreal Why don't add it both queries to perf test? |
Contributor
|
Internal documentation ticket: DOCSUP-16608. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added new JSONExtractKeys function
...
Detailed description / Documentation draft:
JSONExtractKeys(json[, indices_or_keys]…)
Returns an array with keys of JSON.
Example:
SELECT JSONExtractKeys('{"a": "hello", "b": [-100, 200.0, 300]}') = ('a','b');