Merged
Conversation
robot-clickhouse
added
the
pr-build
This was referenced Oct 12, 2021
Member
|
Great! So now #29594 can be reverted. @alexey-milovidov can you also revert it within this PR? |
Member
Author
|
Ok, will do. To finish this PR:
|
robot-ch-test-poll2
added
the
submodule changed
This was referenced Nov 26, 2021
Merged
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jan 24, 2022
…bundled libc) This patch reverts glibc compatibility (via .symver) ClickHouse#29594, in favor of hermetic build (that provides bundled libc version) ClickHouse#30011 Signed-off-by: Azat Khuzhin <[email protected]>
Contributor
|
@alexey-milovidov |
Member
Are you sure it's the same problem? The hermetic build works fine for me with an even newer glibc: |
Member
Author
|
We don't access the system's libc during build time. So, the build is hermetic in this regard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Hermetic builds: use fixed version of libc and make sure that no source or binary files from the host OS are using during build. This closes #27133. This closes #21435. This closes #30462.
Detailed description / Documentation draft:
See also #24371 and #22113.