Merged
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
src/Interpreters/Context.cpp
Outdated
| { | ||
| if (zk) | ||
| zk->finalize(); | ||
| zk->finalize("config changed"); |
Member
There was a problem hiding this comment.
LGTM, but... all messages are from Capital letter but this not. Let's fix it.
Member
Author
There was a problem hiding this comment.
Actually all messages start from lowecase letter (see #29901), but "Operation timeout" starts from a capital because we already have "Operation timeout" in other places and it will be more convenient to grep. Will change other messages to start from a capital too for consistency.
alexey-milovidov
approved these changes
Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Detailed description / Documentation draft:
Follow-up to #29901, avoids messages like this:
"Finalizing session 1: finalization_started=false, queue_closed=false, reason=unknown"