Skip to content

Experiment with minimized toolchain (2)#29974

Merged
alexey-milovidov merged 15 commits intomasterfrom
minimized-toolchain
Oct 11, 2021
Merged

Experiment with minimized toolchain (2)#29974
alexey-milovidov merged 15 commits intomasterfrom
minimized-toolchain

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Oct 11, 2021 •
edited
Loading

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Leave only required files in cross-compile toolchains. Include them as submodules (earlier they were downloaded as tarballs).

Motivation:

@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Oct 11, 2021
@alexey-milovidov alexey-milovidov mentioned this pull request Oct 11, 2021
Closed
@robot-ch-test-poll4 robot-ch-test-poll4 added the submodule changed At least one submodule changed in this PR. label Oct 11, 2021
@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Oct 11, 2021

We will be able to add protoc and llvm-tblgen there and enable more libraries.

azat
azat reviewed Oct 11, 2021
View reviewed changes
cmake/linux/toolchain-x86_64.cmake
@@ -0,0 +1,32 @@
set (CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY)
Copy link
Copy Markdown
Member

@azat azat Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But where have you set CMAKE_TOOLCHAIN_FILE to this toolchain file?

Copy link
Copy Markdown
Member Author

@alexey-milovidov alexey-milovidov Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently in command line.

I've just tested that it works. I plan to also set it by default either in CMakeLists.txt on top or in PreLoad.cmake if the former is not possible.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Oct 11, 2021

Special build check Ok.

Something strange with PVS-Studio...

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Oct 11, 2021

Fixed PVS-Studio.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Oct 11, 2021

I've found how to build protoc for host system instead of target system during cross-compile.
It requires recursive invocation of cmake and it is done this way for llvm-tblgen.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Oct 11, 2021

I've successfully built AArch64 binary with all the enabled libraries (LLVM, MySQL, Protobuf, GRPC, Parquet/ORC/Avro).

Most likely it's due to the fact that I have QEMU with binfmt-misc and AArch64 glibc installed,
and protoc works even compiled for target arch.

@alexey-milovidov alexey-milovidov self-assigned this Oct 11, 2021
@alexey-milovidov alexey-milovidov merged commit f1b550c into master Oct 11, 2021
@alexey-milovidov alexey-milovidov deleted the minimized-toolchain branch October 11, 2021 19:04
@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Oct 11, 2021

Documentation: https://github.com/ClickHouse-Extras/sysroot/blob/master/README.md

This was referenced Oct 11, 2021
Closed
Closed
@alexey-milovidov alexey-milovidov mentioned this pull request Dec 9, 2021
Closed
@Mirraz Mirraz mentioned this pull request Apr 7, 2022
Closed
@filimonov filimonov mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azat azat azat left review comments

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-build Pull request with build/testing/packaging improvement submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexey-milovidov @azat @robot-clickhouse @robot-ch-test-poll4