Skip to content

Fix possible data-race between FileChecker and StorageLog/StorageStripeLog#29959

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:log-data-race-file-checker-fix
Oct 14, 2021
Merged

Fix possible data-race between FileChecker and StorageLog/StorageStripeLog#29959
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:log-data-race-file-checker-fix

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Oct 10, 2021

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible data-race between FileChecker and StorageLog/StorageStripeLog

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Oct 10, 2021
@alexey-milovidov alexey-milovidov self-assigned this Oct 10, 2021
@alexey-milovidov
Copy link
Copy Markdown
Member

So, now we are checking in read method? Thank you, looks reasonable!

@azat
Copy link
Copy Markdown
Member Author

azat commented Oct 10, 2021

So, now we are checking in read method?

Yep, and under lock.

@azat azat force-pushed the log-data-race-file-checker-fix branch from 2804c9e to e4db862 Compare October 13, 2021 21:17
@azat
Copy link
Copy Markdown
Member Author

azat commented Oct 14, 2021

@azat azat requested a review from alexey-milovidov October 14, 2021 21:56
@alexey-milovidov alexey-milovidov merged commit 8d694cb into ClickHouse:master Oct 14, 2021
robot-clickhouse pushed a commit that referenced this pull request Oct 15, 2021
robot-clickhouse pushed a commit that referenced this pull request Oct 15, 2021
robot-clickhouse pushed a commit that referenced this pull request Oct 15, 2021
robot-clickhouse pushed a commit that referenced this pull request Oct 15, 2021
robot-clickhouse pushed a commit that referenced this pull request Oct 15, 2021
@azat azat deleted the log-data-race-file-checker-fix branch October 15, 2021 07:31
alexey-milovidov added a commit that referenced this pull request Oct 16, 2021
Backport #29959 to 21.10: Fix possible data-race between FileChecker and StorageLog/StorageStripeLog
alexey-milovidov added a commit that referenced this pull request Oct 17, 2021
Backport #29959 to 21.8: Fix possible data-race between FileChecker and StorageLog/StorageStripeLog
alexey-milovidov added a commit that referenced this pull request Oct 17, 2021
Backport #29959 to 21.9: Fix possible data-race between FileChecker and StorageLog/StorageStripeLog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants