Fix system tables recreation check (fails to detect changes in enum values)#29857
Merged
kitaisreal merged 1 commit intoClickHouse:masterfrom Oct 7, 2021
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
This was referenced Oct 7, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 8, 2021
…o detect changes in enum values)
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 8, 2021
… detect changes in enum values)
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 8, 2021
… detect changes in enum values)
kitaisreal
added a commit
that referenced
this pull request
Oct 8, 2021
Backport #29857 to 21.9: Fix system tables recreation check (fails to detect changes in enum values)
kitaisreal
added a commit
that referenced
this pull request
Oct 8, 2021
Backport #29857 to 21.8: Fix system tables recreation check (fails to detect changes in enum values)
kitaisreal
added a commit
that referenced
this pull request
Oct 8, 2021
Backport #29857 to 21.10: Fix system tables recreation check (fails to detect changes in enum values)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix system tables recreation check (fails to detect changes in enum values)
getTreeHash()does takes all possible values of enum into account, and so if someone will extend some Enum type then the table will not be recreated.Fixes: #23934 (cc @kitaisreal)
NOTE: although seems that the definition of tables hadn't been changed in that way that
getTreeHashcannot detect the change, so I guess no need to backport