Conversation
robot-clickhouse
added
the
pr-bugfix
Member
Author
|
Functional stateless tests (thread) — Timeout - https://nda.ya.ru/t/lm8r0tkf4KYmHu |
Avogar
approved these changes
Oct 7, 2021
This was referenced Oct 7, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 7, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 7, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 7, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 7, 2021
tavplubix
added a commit
that referenced
this pull request
Oct 11, 2021
Backport #29811 to 21.9: Fix overflow in Stopwatch
tavplubix
added a commit
that referenced
this pull request
Oct 11, 2021
Backport #29811 to 21.10: Fix overflow in Stopwatch
tavplubix
added a commit
that referenced
this pull request
Oct 11, 2021
Backport #29811 to 21.8: Fix overflow in Stopwatch
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
May 12, 2023
…tonic clock)
There is no bug in Linux, the issue that CLOCK_MONOTONIC returns values
less then previous calls likely happens due to adjtime(3) (NTP), since
CLOCK_MONOTONIC is affected by it, and I've seen lots of slight time
modifications due to NTP on the servers. And even on my desktop (I also
have NTP enabled):
CLOCK_MONOTONIC: 189292.803 (2 days + 4h 34m 52s)
CLOCK_MONOTONIC_RAW: 189290.016 (2 days + 4h 34m 50s)
However on Linux there is CLOCK_MONOTONIC_RAW, it is similar to
CLOCK_MONOTONIC, but does not affected by the adjtime(3).
About performance, it is the same:
CLOCK_MONOTONIC 10e6: real=0m0.191s user=0m0.190s sys=0m0.000s
CLOCK_MONOTONIC_RAW 10e6: real=0m0.191s user=0m0.191s sys=0m0.000s
Ops/s:
- AMD Threadripper: 52.3e6
- Xeon Silver 4216 2.10: 46.5e6
Fixes: c5d631c
Fixes: ClickHouse#29811 (cc @tavplubix)
Signed-off-by: Azat Khuzhin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Avoid
Timeout exceeded: elapsed 18446744073.709553 secondserror that might happen in extremely rare cases, presumably due to some bug in kernel. Fixes #29154.