Skip to content

Backport #29337 to 21.8: Fix vertical projection merges#29676

Merged
KochetovNicolai merged 5418 commits into21.8from
backport/21.8/29337
Oct 3, 2021
Merged

Backport #29337 to 21.8: Fix vertical projection merges#29676
KochetovNicolai merged 5418 commits into21.8from
backport/21.8/29337

Conversation

@KochetovNicolai
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

azat and others added 30 commits September 21, 2021 10:53
Update SECURITY.md: change email and the list of versions.
update instructions for `maxfiles` plist file use
Fix terminate on uncaught exception
…-DOCSUP-14537-document_the_log_queries_probability_setting
CurtizJ and others added 23 commits September 26, 2021 14:59
Add GraphCDN in adopter list
Fix comments in AggregateFunctionFactory
Fix H3 function name (h3ResIsClassIII to h3IsResClassIII)
If ReplicatedAccessStorage startup was not executing or if it
failed before completing (for instance when ZooKeeper was not configured),
its destructor would call shutdown and try to join a missing thread.
This should fix the following SIGSEGV, that was found on CI [1]:

    <Fatal> BaseDaemon: Address: NULL pointer. Access: read. Unknown si_code.
    <Fatal> BaseDaemon: 4.4. inlined from ../contrib/rocksdb/utilities/object_registry.cc:19: rocksdb::ObjectLibrary::FindEntry() const
    ...
    <Fatal> BaseDaemon: 7.3. inlined from ../contrib/rocksdb/options/cf_options.cc:678: rocksdb::$_7::operator()()

  [1]: https://clickhouse-test-reports.s3.yandex.net/29341/2b2bec3679df7965af908ce3f1e8e17e39bd12fe/integration_tests_flaky_check_(asan).html#fail1

And also I checked manually with TSan binary, and here is a data race
reported by TSan:

    WARNING: ThreadSanitizer: data race (pid=3356)
      Read of size 8 at 0x7b0c0008cca8 by thread T40:
        2 rocksdb::ObjectLibrary::FindEntry() const obj-x86_64-linux-gnu/../contrib/rocksdb/utilities/object_registry.cc:18:27 (clickhouse-tsan+0x1b839a6c)
        ...
        6 rocksdb::$_7::operator()() const obj-x86_64-linux-gnu/../contrib/rocksdb/options/cf_options.cc:676:32 (clickhouse-tsan+0x1b6bfa63)
        ...
        28 rocksdb::GetColumnFamilyOptionsFromMap() obj-x86_64-linux-gnu/../contrib/rocksdb/options/options_helper.cc:727:10 (clickhouse-tsan+0x1b6fffd2)
        29 DB::StorageEmbeddedRocksDB::initDb() obj-x86_64-linux-gnu/../src/Storages/RocksDB/StorageEmbeddedRocksDB.cpp:359:26 (clickhouse-tsan+0x14195e31)
        ...

      Previous write of size 8 at 0x7b0c0008cca8 by thread T41:
        ...
        9 rocksdb::ObjectLibrary::AddEntry() obj-x86_64-linux-gnu/../contrib/rocksdb/utilities/object_registry.cc:31:19 (clickhouse-tsan+0x1b8392fc)
        ...
        11 rocksdb::RegisterTableFactories()::$_0::operator()() const obj-x86_64-linux-gnu/../contrib/rocksdb/table/table_factory.cc:23:14 (clickhouse-tsan+0x1b7ea94c)
        ...
        43 rocksdb::GetColumnFamilyOptionsFromMap() obj-x86_64-linux-gnu/../contrib/rocksdb/options/options_helper.cc:727:10 (clickhouse-tsan+0x1b6fffd2)
        44 DB::StorageEmbeddedRocksDB::initDb() obj-x86_64-linux-gnu/../src/Storages/RocksDB/StorageEmbeddedRocksDB.cpp:359:26 (clickhouse-tsan+0x14195e31)

Refs: ClickHouse/rocksdb#13
Fixes: #29341
Before this patch:

    $ clickhouse-client --database foo -q 'select 1'
    Code: 32. DB::Exception: Attempt to read after eof: while receiving packet from localhost:9000. (ATTEMPT_TO_READ_AFTER_EOF)

After:

    $ clickhouse-client --database foo -q 'select 1'
    Received exception from server (version 21.11.1):
    Code: 81. DB::Exception: Received from localhost:9000. DB::Exception: Database foo doesn't exist. (UNKNOWN_DATABASE)
    (query: select 1)

Fixes: #26864 (cc @vitlibar)
Send UNKNOWN_DATABASE to the client (via TCP)
test_send_crash_reports: suppress Fatal messages check (due to explicit SIGSEGV)
Fix assert in table function `merge` with database regexp
rocksdb: fix race condition during multiple DB opening
…ages

Better exception messages for some String-related functions
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 3, 2021
@KochetovNicolai KochetovNicolai merged commit 9034c6d into 21.8 Oct 3, 2021
@KochetovNicolai KochetovNicolai deleted the backport/21.8/29337 branch October 3, 2021 07:20
@ClickHouse ClickHouse deleted a comment from CLAassistant Oct 3, 2021
@ClickHouse ClickHouse deleted a comment from CLAassistant Oct 4, 2021
@ClickHouse ClickHouse deleted a comment from CLAassistant Oct 4, 2021
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 26, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
13 out of 14 committers have signed the CLA.

✅ bharatnc
✅ alexey-milovidov
✅ azat
✅ Enmk
✅ CurtizJ
✅ kssenii
✅ KochetovNicolai
✅ kitaisreal
✅ kmichel-aiven
✅ tavplubix
✅ sdil
✅ amosbird
✅ vdimir
❌ 万康


万康 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.