More enhancements for query obfuscator#29672
Merged
alexey-milovidov merged 7 commits intomasterfrom Oct 20, 2021
Merged
Conversation
robot-clickhouse
added
the
pr-improvement
mathalex
reviewed
Oct 14, 2021
src/IO/ReadHelpers.h
Outdated
| if (has_sign || has_number) | ||
| /// 123+ or +123+, just stop after 123 or +123. | ||
| if (has_number) | ||
| return ReturnType(true); |
Contributor
There was a problem hiding this comment.
We return true but do not initialize x. Is it ok? So now several build checks fail due to possible uninitialized variable. Maybe we can just add x = 0; at the beginning or fix something in this part?
Member
Author
There was a problem hiding this comment.
I expect that has_number is true iff at least one digit was read. Let me check...
Member
Author
There was a problem hiding this comment.
You are right, the code is incorrect.
alexey-milovidov
force-pushed
the
clickhouse-obfuscator-2
branch
from
7b40cb0 to
c2faf45
Compare
mathalex
approved these changes
Oct 20, 2021
Contributor
mathalex
left a comment
mathalex
left a comment
There was a problem hiding this comment.
All failed tests are not related to this PR, as I can understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Query obfuscator
clickhouse-format --obfuscatenow works with more types of queries.