Fix missing condition in pushed down predicate.#29625
Merged
KochetovNicolai merged 1 commit intomasterfrom Oct 4, 2021
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
KochetovNicolai
deleted the
fix-missing-condition-with-predicate-push-down
branch
This was referenced Oct 4, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 4, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 4, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 4, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 4, 2021
KochetovNicolai
added a commit
that referenced
this pull request
Oct 12, 2021
Backport #29625 to 21.7: Fix missing condition in pushed down predicate.
KochetovNicolai
added a commit
that referenced
this pull request
Oct 12, 2021
Backport #29625 to 21.8: Fix missing condition in pushed down predicate.
KochetovNicolai
added a commit
that referenced
this pull request
Oct 12, 2021
Backport #29625 to 21.9: Fix missing condition in pushed down predicate.
KochetovNicolai
added a commit
that referenced
this pull request
Oct 12, 2021
Backport #29625 to 21.10: Fix missing condition in pushed down predicate.
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 12, 2021
KochetovNicolai
added a commit
that referenced
this pull request
Oct 13, 2021
Backport #29625 to 21.3: Fix missing condition in pushed down predicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Condition in filter predicate could be lost after push-down optimisation.
In added query, last condition
x = 1could be lost, cause it was traversed as a part of(x = 1 or x != 1)before.