Fix ReplicatedAccessStorage shutdown without startup#29388
Merged
vdimir merged 1 commit intoClickHouse:masterfrom Sep 27, 2021
Merged
Fix ReplicatedAccessStorage shutdown without startup#29388vdimir merged 1 commit intoClickHouse:masterfrom
vdimir merged 1 commit intoClickHouse:masterfrom
Conversation
vdimir
approved these changes
Sep 26, 2021
If ReplicatedAccessStorage startup was not executing or if it failed before completing (for instance when ZooKeeper was not configured), its destructor would call shutdown and try to join a missing thread.
20fae29 to
13db65f
Compare
This was referenced Sep 27, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 27, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If ReplicatedAccessStorage startup was not executed or if it failed before completing (for instance when ZooKeeper was not configured), its destructor would call shutdown and try to join a missing thread.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix replicated access storage not shutting down cleanly when misconfigured