Fix H3 function name (h3ResIsClassIII to h3IsResClassIII)#29368
Merged
alexey-milovidov merged 5 commits intoClickHouse:masterfrom Sep 26, 2021
bharatnc:ncb/fix-name-h3isResClassIII
Merged
Fix H3 function name (h3ResIsClassIII to h3IsResClassIII)#29368alexey-milovidov merged 5 commits intoClickHouse:masterfrom bharatnc:ncb/fix-name-h3isResClassIII
alexey-milovidov merged 5 commits intoClickHouse:masterfrom
bharatnc:ncb/fix-name-h3isResClassIII
Conversation
robot-clickhouse
added
the
pr-bugfix
Contributor
Author
|
@kitaisreal, my bad that I just noticed that this function name is slightly misplaced. It should be |
Contributor
|
@bharatnc from my perspective we should just merge it without backport or changelog. |
Contributor
Author
Sure, sounds good to me. |
kitaisreal
approved these changes
Sep 25, 2021
kitaisreal
removed
the
pr-bugfix
robot-clickhouse
added
the
pr-bugfix
Contributor
|
@bharatnc could you please check tests failures ? |
Contributor
Author
👍 missed renaming the reference file. |
robot-clickhouse
added
pr-not-for-changelog
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Rename H3 function
h3ResIsClassIIItoh3IsResClassIIIto be consistent with the upstream H3 api.