Skip to content

fix build error in keeper data dumper#29367

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
MaxWk:fix-keeper-data-dumper-build-error
Sep 26, 2021
Merged

fix build error in keeper data dumper#29367
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
MaxWk:fix-keeper-data-dumper-build-error

Conversation

@MaxWk
Copy link
Copy Markdown
Contributor

@MaxWk MaxWk commented Sep 25, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
N/A
Detailed description / Documentation draft:

#29223 add a parameter with no default value to the constructor of KeeperLogStore. see #29366 for details

By adding documentation, you'll allow users to try your new feature immediately, not when someone else will have time to document it later. Documentation is necessary for all features that affect user experience in any way. You can add brief documentation draft above, or add documentation right into your patch as Markdown files in docs folder.

If you are doing this for the first time, it's recommended to read the lightweight Contributing to ClickHouse Documentation guide first.

Information about CI checks: https://clickhouse.tech/docs/en/development/continuous-integration/

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Sep 25, 2021
@alexey-milovidov
Copy link
Copy Markdown
Member

I'd better add the value in call site than adding default parameter for function.

@alexey-milovidov alexey-milovidov self-assigned this Sep 25, 2021
@alexey-milovidov alexey-milovidov added can be tested and removed pr-bugfix Pull request with bugfix, not backported by default labels Sep 25, 2021
@robot-clickhouse robot-clickhouse added pr-bugfix Pull request with bugfix, not backported by default pr-build Pull request with build/testing/packaging improvement and removed pr-bugfix Pull request with bugfix, not backported by default labels Sep 25, 2021
@MaxWk MaxWk force-pushed the fix-keeper-data-dumper-build-error branch from 4e23e00 to 3ef5d13 Compare September 26, 2021 02:15
@alexey-milovidov alexey-milovidov merged commit b0d45b8 into ClickHouse:master Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-build Pull request with build/testing/packaging improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants