Skip to content

Remove window function 'nth_value'#29348

Merged
alexey-milovidov merged 1 commit intomasterfrom
remove-nth-value
Sep 25, 2021
Merged

Remove window function 'nth_value'#29348
alexey-milovidov merged 1 commit intomasterfrom
remove-nth-value

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Remove window function nth_value as it is not memory-safe. This closes #29347.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Sep 25, 2021
@amosbird
Copy link
Copy Markdown
Collaborator

@ryzuo Perhaps you can try to fix #29347 fast enough before nth_value gets removed? The feature is already in 21.9 stable.

@ryzuo
Copy link
Copy Markdown

ryzuo commented Sep 25, 2021

@ryzuo Perhaps you can try to fix #29347 fast enough before nth_value gets removed? The feature is already in 21.9 stable.

I will take a look

@alexey-milovidov alexey-milovidov self-assigned this Sep 25, 2021
@alexey-milovidov alexey-milovidov merged commit 87d9506 into master Sep 25, 2021
@alexey-milovidov alexey-milovidov deleted the remove-nth-value branch September 25, 2021 16:43
@alexey-milovidov
Copy link
Copy Markdown
Member Author

It should be easy to fix, but... let's remove first and add back later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uninitialized memory in window function nth_value

4 participants