Skip to content

Fix assertion in DDLDependencyVisitor#29323

Merged
tavplubix merged 1 commit intomasterfrom
fix_assertion_ddl_dependency
Sep 27, 2021
Merged

Fix assertion in DDLDependencyVisitor#29323
tavplubix merged 1 commit intomasterfrom
fix_assertion_ddl_dependency

Conversation

@tavplubix
Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Detailed description / Documentation draft:
https://paste.yandex-team.ru/5442420

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 24, 2021
Copy link
Copy Markdown
Member

@alesapin alesapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I suspect, this logic was not so reliable :)

@alesapin alesapin self-assigned this Sep 27, 2021
@tavplubix
Copy link
Copy Markdown
Member Author

Functional stateless tests (memory) - 01114_database_atomic - 0_o, have no ideas why it failed, drop query was finished before select query according to server log (as expected), will try to debug the test
Functional stateless tests (release) - 00652_replicated_mutations_zookeeper - logical race condition between ReplicatedMergeTreeQueue::updateMutations and StorageReplicatedMergeTree::waitMutationToFinishOnReplicas
Functional stateless tests flaky check (address) - Test runs too long (> 60s) - OK
Integration tests used to be broken in master

@tavplubix tavplubix merged commit e9749b0 into master Sep 27, 2021
@tavplubix tavplubix deleted the fix_assertion_ddl_dependency branch September 27, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants